From patchwork Sun May 7 16:26:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13233836 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E8A3C77B7C for ; Sun, 7 May 2023 16:28:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AC18710E2C4; Sun, 7 May 2023 16:27:38 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id D6D1D10E263 for ; Sun, 7 May 2023 16:26:49 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvhDd-0002Mg-5Q; Sun, 07 May 2023 18:26:41 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pvhDc-001nEt-BZ; Sun, 07 May 2023 18:26:40 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pvhDb-002Aia-BC; Sun, 07 May 2023 18:26:39 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: David Airlie , Daniel Vetter , Maxime Ripard , =?utf-8?q?Ma=C3=ADra_Canal?= , Javier Martinez Canillas , =?utf-8?q?Noralf_Tr=C3=B8nne?= =?utf-8?q?s?= Subject: [PATCH 45/53] drm/tests: helpers: Convert to platform remove callback returning void Date: Sun, 7 May 2023 18:26:08 +0200 Message-Id: <20230507162616.1368908-46-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> References: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1411; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=/Wl1/d5wmThPaeOs36gLx2V+XCXAjo2ehAY2HF9yWDE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkV9EYb0QBN/wqquX3jsjGowxwv+JNlGwVkVCj+ P1xIHfd8ZaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZFfRGAAKCRCPgPtYfRL+ TuXeCACzZ27KjfHbWEtcx383YThpSo1MYVf9ddv5eiwVrgxYRusuF4Bjx99YoKRk9TwP1IN0+9t AP97kdZrUvEqc711/l0uKqTuypHL4KE6i8XBPpMdwg4PoMlYwbpm5ghb+htkRFb5xJ6nDoImh0i jxs/gYgApz7wm40J1czgLkY1ijUoKs14z5sslLtofl2hGUxSfjGdAbU2Nh1oeVaMTQyNHEDEKTB mkChMrPoH/EepAscZPA/okqL3VScmH/5Hl2AYwOmPro0khmLgQCBAH/Vx4X9Yo2gUnxsqHvCjA8 LeiWP03/nAGMa8K7cHmBHQNQ5c23mI+WhcBfOW8bZohVreYT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c index e98b4150f556..049b98daedbb 100644 --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c @@ -19,14 +19,13 @@ static int fake_probe(struct platform_device *pdev) return 0; } -static int fake_remove(struct platform_device *pdev) +static void fake_remove(struct platform_device *pdev) { - return 0; } static struct platform_driver fake_platform_driver = { .probe = fake_probe, - .remove = fake_remove, + .remove_new = fake_remove, .driver = { .name = KUNIT_DEVICE_NAME, },