| Message ID | 20230507162616.1368908-49-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Convert to platform remove callback returning void | expand |
Hi, the subject line is a bit ugly. You may want to change the it to say either 'drm/tiny/arcgpu' or just 'drm/arcgpu'. Same for the other tiny/-related patches. Best regards Thomas Am 07.05.23 um 18:26 schrieb Uwe Kleine-König: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/gpu/drm/tiny/arcpgu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c > index 611bbee15071..a1f998a85ce8 100644 > --- a/drivers/gpu/drm/tiny/arcpgu.c > +++ b/drivers/gpu/drm/tiny/arcpgu.c > @@ -404,14 +404,12 @@ static int arcpgu_probe(struct platform_device *pdev) > return ret; > } > > -static int arcpgu_remove(struct platform_device *pdev) > +static void arcpgu_remove(struct platform_device *pdev) > { > struct drm_device *drm = platform_get_drvdata(pdev); > > drm_dev_unregister(drm); > arcpgu_unload(drm); > - > - return 0; > } > > static const struct of_device_id arcpgu_of_table[] = { > @@ -423,7 +421,7 @@ MODULE_DEVICE_TABLE(of, arcpgu_of_table); > > static struct platform_driver arcpgu_platform_driver = { > .probe = arcpgu_probe, > - .remove = arcpgu_remove, > + .remove_new = arcpgu_remove, > .driver = { > .name = "arcpgu", > .of_match_table = arcpgu_of_table,
On Mon, May 08, 2023 at 09:03:30AM +0200, Thomas Zimmermann wrote: > Hi, > > the subject line is a bit ugly. You may want to change the it to say either > 'drm/tiny/arcgpu' or just 'drm/arcgpu'. Same for the other tiny/-related > patches. Oh, indeed non-optimal. There is this patch touching arcpgu and the next touching ofdrm + simpledrm; both have the same commit log. The obvious possibilities are: Squash them together and keep "drm/tiny" as prefix, or split in three and use "drm/arcpgu", "drm/ofdrm" and "drm/simpledrm" as prefix respectively (with or without "tiny/"). If I don't hear back about this, I'll go for splitting and no "tiny/" (which seems to be the more common one in the past). Best regards and thanks for your feedback, Uwe
diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c index 611bbee15071..a1f998a85ce8 100644 --- a/drivers/gpu/drm/tiny/arcpgu.c +++ b/drivers/gpu/drm/tiny/arcpgu.c @@ -404,14 +404,12 @@ static int arcpgu_probe(struct platform_device *pdev) return ret; } -static int arcpgu_remove(struct platform_device *pdev) +static void arcpgu_remove(struct platform_device *pdev) { struct drm_device *drm = platform_get_drvdata(pdev); drm_dev_unregister(drm); arcpgu_unload(drm); - - return 0; } static const struct of_device_id arcpgu_of_table[] = { @@ -423,7 +421,7 @@ MODULE_DEVICE_TABLE(of, arcpgu_of_table); static struct platform_driver arcpgu_platform_driver = { .probe = arcpgu_probe, - .remove = arcpgu_remove, + .remove_new = arcpgu_remove, .driver = { .name = "arcpgu", .of_match_table = arcpgu_of_table,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/gpu/drm/tiny/arcpgu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)