| Message ID | 20230507202848.207608-1-mcanal@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] drm: Add fixed-point helper to get rounded integer values | expand |
On 07/05/23 17:28, Maíra Canal wrote: > Create a new fixed-point helper to allow us to return the rounded value > of our fixed-point value. > > Signed-off-by: Maíra Canal <mcanal@igalia.com> > --- > > v1 -> v2: https://lore.kernel.org/dri-devel/20230425153353.238844-1-mcanal@igalia.com/T/ > > * New patch > * Create the function drm_fixp2int_round() (Melissa Wen). > > --- > include/drm/drm_fixed.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h > index 255645c1f9a8..d695d0411e2d 100644 > --- a/include/drm/drm_fixed.h > +++ b/include/drm/drm_fixed.h > @@ -71,6 +71,7 @@ static inline u32 dfixed_div(fixed20_12 A, fixed20_12 B) > } > > #define DRM_FIXED_POINT 32 > +#define DRM_FIXED_POINT_HALF 16 > #define DRM_FIXED_ONE (1ULL << DRM_FIXED_POINT) > #define DRM_FIXED_DECIMAL_MASK (DRM_FIXED_ONE - 1) > #define DRM_FIXED_DIGITS_MASK (~DRM_FIXED_DECIMAL_MASK) > @@ -87,6 +88,11 @@ static inline int drm_fixp2int(s64 a) > return ((s64)a) >> DRM_FIXED_POINT; > } > > +static inline int drm_fixp2int_round(s64 a) > +{ > + return ((s64)a + (1 << (DRM_FIXED_POINT_HALF - 1))) >> DRM_FIXED_POINT; I think it would be great to use drm_fixp2int, instead of shifting manually, like drm_fixp2int_ceil does. Best Regards, ~Arthur Grillo > +} > + > static inline int drm_fixp2int_ceil(s64 a) > { > if (a > 0)
diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h index 255645c1f9a8..d695d0411e2d 100644 --- a/include/drm/drm_fixed.h +++ b/include/drm/drm_fixed.h @@ -71,6 +71,7 @@ static inline u32 dfixed_div(fixed20_12 A, fixed20_12 B) } #define DRM_FIXED_POINT 32 +#define DRM_FIXED_POINT_HALF 16 #define DRM_FIXED_ONE (1ULL << DRM_FIXED_POINT) #define DRM_FIXED_DECIMAL_MASK (DRM_FIXED_ONE - 1) #define DRM_FIXED_DIGITS_MASK (~DRM_FIXED_DECIMAL_MASK) @@ -87,6 +88,11 @@ static inline int drm_fixp2int(s64 a) return ((s64)a) >> DRM_FIXED_POINT; } +static inline int drm_fixp2int_round(s64 a) +{ + return ((s64)a + (1 << (DRM_FIXED_POINT_HALF - 1))) >> DRM_FIXED_POINT; +} + static inline int drm_fixp2int_ceil(s64 a) { if (a > 0)
Create a new fixed-point helper to allow us to return the rounded value of our fixed-point value. Signed-off-by: Maíra Canal <mcanal@igalia.com> --- v1 -> v2: https://lore.kernel.org/dri-devel/20230425153353.238844-1-mcanal@igalia.com/T/ * New patch * Create the function drm_fixp2int_round() (Melissa Wen). --- include/drm/drm_fixed.h | 6 ++++++ 1 file changed, 6 insertions(+)