| Message ID | 20230517190356.349044-1-luben.tuikov@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/sched: Rename to drm_sched_can_queue() | expand |
On Wed, May 17, 2023 at 3:04 PM Luben Tuikov <luben.tuikov@amd.com> wrote: > > Rename drm_sched_ready() to drm_sched_can_queue(). "ready" can mean many > things and is thus meaningless in this context. Instead, rename to a name > which precisely conveys what is being checked. > > Cc: Christian König <christian.koenig@amd.com> > Cc: Alex Deucher <Alexander.Deucher@amd.com> > Signed-off-by: Luben Tuikov <luben.tuikov@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/scheduler/sched_main.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c > index 172e63c87bfcf3..8739322c30321b 100644 > --- a/drivers/gpu/drm/scheduler/sched_main.c > +++ b/drivers/gpu/drm/scheduler/sched_main.c > @@ -848,13 +848,12 @@ void drm_sched_job_cleanup(struct drm_sched_job *job) > EXPORT_SYMBOL(drm_sched_job_cleanup); > > /** > - * drm_sched_ready - is the scheduler ready > - * > + * drm_sched_can_queue -- Can we queue more to the hardware? > * @sched: scheduler instance > * > * Return true if we can push more jobs to the hw, otherwise false. > */ > -static bool drm_sched_ready(struct drm_gpu_scheduler *sched) > +static bool drm_sched_can_queue(struct drm_gpu_scheduler *sched) > { > return atomic_read(&sched->hw_rq_count) < > sched->hw_submission_limit; > @@ -868,7 +867,7 @@ static bool drm_sched_ready(struct drm_gpu_scheduler *sched) > */ > void drm_sched_wakeup(struct drm_gpu_scheduler *sched) > { > - if (drm_sched_ready(sched)) > + if (drm_sched_can_queue(sched)) > wake_up_interruptible(&sched->wake_up_worker); > } > > @@ -885,7 +884,7 @@ drm_sched_select_entity(struct drm_gpu_scheduler *sched) > struct drm_sched_entity *entity; > int i; > > - if (!drm_sched_ready(sched)) > + if (!drm_sched_can_queue(sched)) > return NULL; > > /* Kernel run queue has higher priority than normal run queue*/ > > base-commit: f47d6140b7a4c858d82d263e7577ff6fb5279a9c > -- > 2.40.1 >
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 172e63c87bfcf3..8739322c30321b 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -848,13 +848,12 @@ void drm_sched_job_cleanup(struct drm_sched_job *job) EXPORT_SYMBOL(drm_sched_job_cleanup); /** - * drm_sched_ready - is the scheduler ready - * + * drm_sched_can_queue -- Can we queue more to the hardware? * @sched: scheduler instance * * Return true if we can push more jobs to the hw, otherwise false. */ -static bool drm_sched_ready(struct drm_gpu_scheduler *sched) +static bool drm_sched_can_queue(struct drm_gpu_scheduler *sched) { return atomic_read(&sched->hw_rq_count) < sched->hw_submission_limit; @@ -868,7 +867,7 @@ static bool drm_sched_ready(struct drm_gpu_scheduler *sched) */ void drm_sched_wakeup(struct drm_gpu_scheduler *sched) { - if (drm_sched_ready(sched)) + if (drm_sched_can_queue(sched)) wake_up_interruptible(&sched->wake_up_worker); } @@ -885,7 +884,7 @@ drm_sched_select_entity(struct drm_gpu_scheduler *sched) struct drm_sched_entity *entity; int i; - if (!drm_sched_ready(sched)) + if (!drm_sched_can_queue(sched)) return NULL; /* Kernel run queue has higher priority than normal run queue*/
Rename drm_sched_ready() to drm_sched_can_queue(). "ready" can mean many things and is thus meaningless in this context. Instead, rename to a name which precisely conveys what is being checked. Cc: Christian König <christian.koenig@amd.com> Cc: Alex Deucher <Alexander.Deucher@amd.com> Signed-off-by: Luben Tuikov <luben.tuikov@amd.com> --- drivers/gpu/drm/scheduler/sched_main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) base-commit: f47d6140b7a4c858d82d263e7577ff6fb5279a9c