From patchwork Tue May 23 15:16:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 13252511 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87254C7EE26 for ; Tue, 23 May 2023 15:17:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86D8710E452; Tue, 23 May 2023 15:17:44 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id C36CA10E452; Tue, 23 May 2023 15:17:42 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 06C85618E6; Tue, 23 May 2023 15:17:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6381BC433D2; Tue, 23 May 2023 15:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684855061; bh=D2TI28zRqMeP33qD4AGJWV2hUnE/pn90ek046LImn8g=; h=From:To:Cc:Subject:Date:From; b=aCoBt0h0f7NnX7GHkpKHx5gX/kOf9gAf60zsdhyzmiEFf+xCbWPbmRlqVY2L+G3uB qHsIFCdiq1Vo2YL79EGMRddXfA7JRKvA2aXHN0efIAUqdMgUpU70iS9t8yoNaPh4KZ DyrY+bUPUsYjBE6py0YTCxEurL/YMVOizJBEywAwYU5NHi4oUJaHRd+XeYfAgLuyZM 0z0XPl9Zw2kcaFZWuqLwG09mIZVspbZef7/Yz3A5M7mw6llm7VBYZ3skX6OCps4Jpx zj9Lh+ZaiZVKPIBANRvV69ER6euCgEo++kYy6qqBNCFycbhItcIyZKJY30Y9NKIhgv Dsmk9u8YB0CZw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1q1Tlg-0007O5-3D; Tue, 23 May 2023 17:17:44 +0200 From: Johan Hovold To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov Subject: [PATCH] Revert "drm/msm/dp: set self refresh aware based on PSR support" Date: Tue, 23 May 2023 17:16:46 +0200 Message-Id: <20230523151646.28366-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Sankeerth Billakanti , Sean Paul , Bjorn Andersson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kuogee Hsieh , linux-arm-msm@vger.kernel.org, Stephen Boyd , Vinod Polimera , Johan Hovold Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This reverts commit 1844e680d56bb0c4e0489138f2b7ba2dc1c988e3. PSR support clearly is not ready for mainline and specifically breaks virtual terminals which are no longer updated when PSR is enabled (e.g. no keyboard input is echoed, no cursor blink). Disable PSR support for now by reverting commit 1844e680d56b ("drm/msm/dp: set self refresh aware based on PSR support"). Cc: Vinod Polimera Cc: Dmitry Baryshkov Signed-off-by: Johan Hovold --- Bjorn reported that PSR support broke virtual terminals two months ago, but this is still broken in 6.4-rc3: https://lore.kernel.org/lkml/20230326162723.3lo6pnsfdwzsvbhj@ripper/ despite the following series that claimed to address this: https://lore.kernel.org/lkml/1680271114-1534-1-git-send-email-quic_vpolimer@quicinc.com Let's revert until this has been fixed properly. Johan drivers/gpu/drm/msm/dp/dp_drm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c index 785d76639497..029e08c5bb06 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -117,8 +117,6 @@ static int edp_bridge_atomic_check(struct drm_bridge *drm_bridge, if (WARN_ON(!conn_state)) return -ENODEV; - conn_state->self_refresh_aware = dp->psr_supported; - if (!conn_state->crtc || !crtc_state) return 0;