| Message ID | 20230526-revert-bad-binding-v1-1-67329ad1bd80@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "dt-bindings: bridge: samsung-dsim: Make some flags optional" | expand |
On Fri, May 26, 2023 at 09:27:16AM +0200, Neil Armstrong wrote: > This reverts commit cfaf76d349837f695c8aa6d7077847fec4231fe5 which was applied > without review due to a bad tool manipulation. Is it a dt-binding maintainer review that you are missing on that patch? For this one: Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > index 360fea81f4b6..9f61ebdfefa8 100644 > --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > @@ -70,9 +70,7 @@ properties: > samsung,burst-clock-frequency: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > - DSIM high speed burst mode frequency when connected to devices > - that support burst mode. If absent, the driver will use the pixel > - clock from the attached device or bridge. > + DSIM high speed burst mode frequency. > > samsung,esc-clock-frequency: > $ref: /schemas/types.yaml#/definitions/uint32 > @@ -82,8 +80,7 @@ properties: > samsung,pll-clock-frequency: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > - DSIM oscillator clock frequency. If absent, the driver will > - use the clock frequency of sclk_mipi. > + DSIM oscillator clock frequency. > > phys: > maxItems: 1 > @@ -137,7 +134,9 @@ required: > - compatible > - interrupts > - reg > + - samsung,burst-clock-frequency > - samsung,esc-clock-frequency > + - samsung,pll-clock-frequency > > allOf: > - $ref: ../dsi-controller.yaml# > > --- > base-commit: cfaf76d349837f695c8aa6d7077847fec4231fe5 > change-id: 20230526-revert-bad-binding-f77a3ca96419 > > Best regards, > -- > Neil Armstrong <neil.armstrong@linaro.org> >
On 26/05/2023 10:02, Conor Dooley wrote: > On Fri, May 26, 2023 at 09:27:16AM +0200, Neil Armstrong wrote: >> This reverts commit cfaf76d349837f695c8aa6d7077847fec4231fe5 which was applied >> without review due to a bad tool manipulation. > > Is it a dt-binding maintainer review that you are missing on that > patch? Exact > > For this one: > Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, I'll apply this revert now and wait until the original bindings patch gets properly reviewed. Thanks, Neil > > Thanks, > Conor. > >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml >> index 360fea81f4b6..9f61ebdfefa8 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml >> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml >> @@ -70,9 +70,7 @@ properties: >> samsung,burst-clock-frequency: >> $ref: /schemas/types.yaml#/definitions/uint32 >> description: >> - DSIM high speed burst mode frequency when connected to devices >> - that support burst mode. If absent, the driver will use the pixel >> - clock from the attached device or bridge. >> + DSIM high speed burst mode frequency. >> >> samsung,esc-clock-frequency: >> $ref: /schemas/types.yaml#/definitions/uint32 >> @@ -82,8 +80,7 @@ properties: >> samsung,pll-clock-frequency: >> $ref: /schemas/types.yaml#/definitions/uint32 >> description: >> - DSIM oscillator clock frequency. If absent, the driver will >> - use the clock frequency of sclk_mipi. >> + DSIM oscillator clock frequency. >> >> phys: >> maxItems: 1 >> @@ -137,7 +134,9 @@ required: >> - compatible >> - interrupts >> - reg >> + - samsung,burst-clock-frequency >> - samsung,esc-clock-frequency >> + - samsung,pll-clock-frequency >> >> allOf: >> - $ref: ../dsi-controller.yaml# >> >> --- >> base-commit: cfaf76d349837f695c8aa6d7077847fec4231fe5 >> change-id: 20230526-revert-bad-binding-f77a3ca96419 >> >> Best regards, >> -- >> Neil Armstrong <neil.armstrong@linaro.org> >>
Hi, On Fri, 26 May 2023 09:27:16 +0200, Neil Armstrong wrote: > This reverts commit cfaf76d349837f695c8aa6d7077847fec4231fe5 which was applied > without review due to a bad tool manipulation. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] Revert "dt-bindings: bridge: samsung-dsim: Make some flags optional" https://cgit.freedesktop.org/drm/drm-misc/commit/?id=35070674f488eefaeb753a13df11199d10328ff8
diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml index 360fea81f4b6..9f61ebdfefa8 100644 --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml @@ -70,9 +70,7 @@ properties: samsung,burst-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM high speed burst mode frequency when connected to devices - that support burst mode. If absent, the driver will use the pixel - clock from the attached device or bridge. + DSIM high speed burst mode frequency. samsung,esc-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 @@ -82,8 +80,7 @@ properties: samsung,pll-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM oscillator clock frequency. If absent, the driver will - use the clock frequency of sclk_mipi. + DSIM oscillator clock frequency. phys: maxItems: 1 @@ -137,7 +134,9 @@ required: - compatible - interrupts - reg + - samsung,burst-clock-frequency - samsung,esc-clock-frequency + - samsung,pll-clock-frequency allOf: - $ref: ../dsi-controller.yaml#
This reverts commit cfaf76d349837f695c8aa6d7077847fec4231fe5 which was applied without review due to a bad tool manipulation. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- base-commit: cfaf76d349837f695c8aa6d7077847fec4231fe5 change-id: 20230526-revert-bad-binding-f77a3ca96419 Best regards,