| Message ID | 20230526100801.16310-1-uwu@icenowy.me (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: mediatek: mt8173-elm: remove panel model number in DT | expand |
On Mon, May 29, 2023 at 12:14 PM Icenowy Zheng <uwu@icenowy.me> wrote: > > 在 2023-05-26星期五的 07:24 -0700，Doug Anderson写道： > > Hi, > > > > On Fri, May 26, 2023 at 3:09 AM Icenowy Zheng <uwu@icenowy.me> wrote: > > > > > > Currently a specific panel number is used in the Elm DTSI, which is > > > corresponded to a 12" panel. However, according to the official > > > Chrome > > > OS devices document, Elm refers to Acer Chromebook R13, which, as > > > the > > > name specifies, uses a 13.3" panel, which comes with EDID > > > information. > > > > > > As the kernel currently prioritizes the hardcoded timing parameters > > > matched with the panel number compatible, a wrong timing will be > > > applied > > > to the 13.3" panel on Acer Chromebook R13, which leads to blank > > > display. > > > > > > Because the Elm DTSI is shared with Hana board, and Hana > > > corresponds to > > > multiple devices from 11" to 14", a certain panel model number > > > shouldn't > > > be present, and driving the panel according to its EDID information > > > is > > > necessary. > > > > > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me> > > > --- > > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > We went through a bunch of back-and-forth here but in the end in the > > ChromeOS tree we have "edp-panel" as the "compatible" here in the > > ChromeOS 5.15 tree and this makes sense. > > I only have Elm, so I am curious that do all Hana's only rely on panel > EDID to use different displays? > > BTW The Chrome OS document say that Elm and Hana are both board based > on Oak baseboard, should the DTSI be renamed mt8173-oak.dtsi, and still > let mt8173-elm.dts include it and then set model information? > Oak is a reference design board which is not in the public. Since only elm and hana board are in the public and the difference between elm and hana are not much, instead of creating oak.dtsi, elm.dtsi (inherit from oak.dtsi), hana.dtsi (inherit from oak.dtsi), we decided to make elm.dtsi as the main dtsi and let hana inherit it and make its own changes. > > > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > > > ...in theory one would wish for a "Fixes" tag, but I think in > > previous > > discussions it was decided that it was too complicated. Hardcoding > > the > > other compatible string has always been technically wrong, but I > > guess > > it worked at some point in time. The more correct way (as you're > > doing > > here) needs the DP AUX bus support and the generic eDP panels, both > > of > > which are significantly newer than the elm dts. So I guess leaving no > > "Fixes" tag is OK, or perhaps you could do the somewhat weak: > > Well I remembered when I was developing the support for Pine64 > Pinebook, which is also an ARM64 laptop with an eDP panel (via a DPI- > eDP bridge, ANX6345). At first I didn't use any panel node in the DT, > and the kernel maintainers argued to the bridge that seems to be > connected to nothing (because DP is a discoverable port), and > fortunately 2 Pinebook SKUs (11.6" and 14") is finally reduced to one, > and it's then possible to hardcode a panel model in the Pinebook DT. > According to my memory, the need to specify the panel is to properly > handle eDP panel power up timing, because it's not a very standard > thing. (Well, in my memory, when I was testing that code, on a > (engineering sample) 14" Pinebook, the EDID timing overrided the > hardcoded 11.6" timing and it properly works, the 14" panel is 1366x768 > but the 11.6" panel is 1920x1080.) > > (BTW when I checked the DT of Olimex TERES-I, which uses the same DPI- > eDP bridge, it is still in the status of a dangling bridge, and of > course it works ;-) ) > > > > > Fixes: c2d94f72140a ("arm64: dts: mediatek: mt8173-elm: Move display > > to ps8640 auxiliary bus") > > Well this sound quite reasonable, as the kernel should have proper AUX > support at this commit. > >
Il 26/05/23 16:24, Doug Anderson ha scritto: > Hi, > > On Fri, May 26, 2023 at 3:09 AM Icenowy Zheng <uwu@icenowy.me> wrote: >> >> Currently a specific panel number is used in the Elm DTSI, which is >> corresponded to a 12" panel. However, according to the official Chrome >> OS devices document, Elm refers to Acer Chromebook R13, which, as the >> name specifies, uses a 13.3" panel, which comes with EDID information. >> >> As the kernel currently prioritizes the hardcoded timing parameters >> matched with the panel number compatible, a wrong timing will be applied >> to the 13.3" panel on Acer Chromebook R13, which leads to blank display. >> >> Because the Elm DTSI is shared with Hana board, and Hana corresponds to >> multiple devices from 11" to 14", a certain panel model number shouldn't >> be present, and driving the panel according to its EDID information is >> necessary. >> >> Signed-off-by: Icenowy Zheng <uwu@icenowy.me> >> --- >> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > We went through a bunch of back-and-forth here but in the end in the > ChromeOS tree we have "edp-panel" as the "compatible" here in the > ChromeOS 5.15 tree and this makes sense. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > ...in theory one would wish for a "Fixes" tag, but I think in previous > discussions it was decided that it was too complicated. Hardcoding the > other compatible string has always been technically wrong, but I guess > it worked at some point in time. The more correct way (as you're doing > here) needs the DP AUX bus support and the generic eDP panels, both of > which are significantly newer than the elm dts. So I guess leaving no > "Fixes" tag is OK, or perhaps you could do the somewhat weak: > > Fixes: c2d94f72140a ("arm64: dts: mediatek: mt8173-elm: Move display > to ps8640 auxiliary bus") I remember I didn't change the compatible to panel-edp because it didn't work at that time, but it does now... I'm not sure what actually fixed that and if the commit(s) was/were backported to that suggested point, so I would leave the Fixes tag out, as that may break older kernels. Anyway, for this commit: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
在 2023-05-29星期一的 10:02 +0200，AngeloGioacchino Del Regno写道： > Il 26/05/23 16:24, Doug Anderson ha scritto: > > Hi, > > > > On Fri, May 26, 2023 at 3:09 AM Icenowy Zheng <uwu@icenowy.me> > > wrote: > > > > > > Currently a specific panel number is used in the Elm DTSI, which > > > is > > > corresponded to a 12" panel. However, according to the official > > > Chrome > > > OS devices document, Elm refers to Acer Chromebook R13, which, as > > > the > > > name specifies, uses a 13.3" panel, which comes with EDID > > > information. > > > > > > As the kernel currently prioritizes the hardcoded timing > > > parameters > > > matched with the panel number compatible, a wrong timing will be > > > applied > > > to the 13.3" panel on Acer Chromebook R13, which leads to blank > > > display. > > > > > > Because the Elm DTSI is shared with Hana board, and Hana > > > corresponds to > > > multiple devices from 11" to 14", a certain panel model number > > > shouldn't > > > be present, and driving the panel according to its EDID > > > information is > > > necessary. > > > > > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me> > > > --- > > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > We went through a bunch of back-and-forth here but in the end in > > the > > ChromeOS tree we have "edp-panel" as the "compatible" here in the > > ChromeOS 5.15 tree and this makes sense. > > > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > > > ...in theory one would wish for a "Fixes" tag, but I think in > > previous > > discussions it was decided that it was too complicated. Hardcoding > > the > > other compatible string has always been technically wrong, but I > > guess > > it worked at some point in time. The more correct way (as you're > > doing > > here) needs the DP AUX bus support and the generic eDP panels, both > > of > > which are significantly newer than the elm dts. So I guess leaving > > no > > "Fixes" tag is OK, or perhaps you could do the somewhat weak: > > > > Fixes: c2d94f72140a ("arm64: dts: mediatek: mt8173-elm: Move > > display > > to ps8640 auxiliary bus") > > I remember I didn't change the compatible to panel-edp because it > didn't > work at that time, but it does now... I'm not sure what actually > fixed that > and if the commit(s) was/were backported to that suggested point, so > I > would leave the Fixes tag out, as that may break older kernel. Well at least I developed this patch on v6.3. (In fact the same kernel config do not boot to system at all on v6.0/v6.1 when I do make olddefconfig then build) > > Anyway, for this commit: > > Reviewed-by: AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com>
On 29/05/2023 10:45, Icenowy Zheng wrote: > 在 2023-05-29星期一的 10:02 +0200，AngeloGioacchino Del Regno写道： >> Il 26/05/23 16:24, Doug Anderson ha scritto: >>> Hi, >>> >>> On Fri, May 26, 2023 at 3:09 AM Icenowy Zheng <uwu@icenowy.me> >>> wrote: >>>> >>>> Currently a specific panel number is used in the Elm DTSI, which >>>> is >>>> corresponded to a 12" panel. However, according to the official >>>> Chrome >>>> OS devices document, Elm refers to Acer Chromebook R13, which, as >>>> the >>>> name specifies, uses a 13.3" panel, which comes with EDID >>>> information. >>>> >>>> As the kernel currently prioritizes the hardcoded timing >>>> parameters >>>> matched with the panel number compatible, a wrong timing will be >>>> applied >>>> to the 13.3" panel on Acer Chromebook R13, which leads to blank >>>> display. >>>> >>>> Because the Elm DTSI is shared with Hana board, and Hana >>>> corresponds to >>>> multiple devices from 11" to 14", a certain panel model number >>>> shouldn't >>>> be present, and driving the panel according to its EDID >>>> information is >>>> necessary. >>>> >>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me> >>>> --- >>>> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> We went through a bunch of back-and-forth here but in the end in >>> the >>> ChromeOS tree we have "edp-panel" as the "compatible" here in the >>> ChromeOS 5.15 tree and this makes sense. >>> >>> Reviewed-by: Douglas Anderson <dianders@chromium.org> >>> >>> ...in theory one would wish for a "Fixes" tag, but I think in >>> previous >>> discussions it was decided that it was too complicated. Hardcoding >>> the >>> other compatible string has always been technically wrong, but I >>> guess >>> it worked at some point in time. The more correct way (as you're >>> doing >>> here) needs the DP AUX bus support and the generic eDP panels, both >>> of >>> which are significantly newer than the elm dts. So I guess leaving >>> no >>> "Fixes" tag is OK, or perhaps you could do the somewhat weak: >>> >>> Fixes: c2d94f72140a ("arm64: dts: mediatek: mt8173-elm: Move >>> display >>> to ps8640 auxiliary bus") >> >> I remember I didn't change the compatible to panel-edp because it >> didn't >> work at that time, but it does now... I'm not sure what actually >> fixed that >> and if the commit(s) was/were backported to that suggested point, so >> I >> would leave the Fixes tag out, as that may break older kernel. > > Well at least I developed this patch on v6.3. > > (In fact the same kernel config do not boot to system at all on > v6.0/v6.1 when I do make olddefconfig then build) > I applied the patch without the fixes tag. Lets stay on the secure side to not break older kernels. Regards, Matthias >> >> Anyway, for this commit: >> >> Reviewed-by: AngeloGioacchino Del Regno >> <angelogioacchino.delregno@collabora.com> >
在 2023-05-29星期一的 18:28 +0200，Matthias Brugger写道： > > > On 29/05/2023 10:45, Icenowy Zheng wrote: > > 在 2023-05-29星期一的 10:02 +0200，AngeloGioacchino Del Regno写道： > > > Il 26/05/23 16:24, Doug Anderson ha scritto: > > > > Hi, > > > > > > > > On Fri, May 26, 2023 at 3:09 AM Icenowy Zheng <uwu@icenowy.me> > > > > wrote: > > > > > > > > > > Currently a specific panel number is used in the Elm DTSI, > > > > > which > > > > > is > > > > > corresponded to a 12" panel. However, according to the > > > > > official > > > > > Chrome > > > > > OS devices document, Elm refers to Acer Chromebook R13, > > > > > which, as > > > > > the > > > > > name specifies, uses a 13.3" panel, which comes with EDID > > > > > information. > > > > > > > > > > As the kernel currently prioritizes the hardcoded timing > > > > > parameters > > > > > matched with the panel number compatible, a wrong timing will > > > > > be > > > > > applied > > > > > to the 13.3" panel on Acer Chromebook R13, which leads to > > > > > blank > > > > > display. > > > > > > > > > > Because the Elm DTSI is shared with Hana board, and Hana > > > > > corresponds to > > > > > multiple devices from 11" to 14", a certain panel model > > > > > number > > > > > shouldn't > > > > > be present, and driving the panel according to its EDID > > > > > information is > > > > > necessary. > > > > > > > > > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me> > > > > > --- > > > > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > We went through a bunch of back-and-forth here but in the end > > > > in > > > > the > > > > ChromeOS tree we have "edp-panel" as the "compatible" here in > > > > the > > > > ChromeOS 5.15 tree and this makes sense. > > > > > > > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > > > > > > > ...in theory one would wish for a "Fixes" tag, but I think in > > > > previous > > > > discussions it was decided that it was too complicated. > > > > Hardcoding > > > > the > > > > other compatible string has always been technically wrong, but > > > > I > > > > guess > > > > it worked at some point in time. The more correct way (as > > > > you're > > > > doing > > > > here) needs the DP AUX bus support and the generic eDP panels, > > > > both > > > > of > > > > which are significantly newer than the elm dts. So I guess > > > > leaving > > > > no > > > > "Fixes" tag is OK, or perhaps you could do the somewhat weak: > > > > > > > > Fixes: c2d94f72140a ("arm64: dts: mediatek: mt8173-elm: Move > > > > display > > > > to ps8640 auxiliary bus") > > > > > > I remember I didn't change the compatible to panel-edp because it > > > didn't > > > work at that time, but it does now... I'm not sure what actually > > > fixed that > > > and if the commit(s) was/were backported to that suggested point, > > > so > > > I > > > would leave the Fixes tag out, as that may break older kernel. > > > > Well at least I developed this patch on v6.3. > > > > (In fact the same kernel config do not boot to system at all on > > v6.0/v6.1 when I do make olddefconfig then build) > > > > I applied the patch without the fixes tag. Lets stay on the secure > side to not > break older kernels. Well I think this patch is at least meaningful to get backported to v6.3. Should we cc stable@vger.kernel.org ? > > Regards, > Matthias > > > > > > > Anyway, for this commit: > > > > > > Reviewed-by: AngeloGioacchino Del Regno > > > <angelogioacchino.delregno@collabora.com> > >
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi index d452cab28c67..737737528eed 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi @@ -285,7 +285,7 @@ ps8640_out: endpoint { aux-bus { panel: panel { - compatible = "lg,lp120up1"; + compatible = "edp-panel"; power-supply = <&panel_fixed_3v3>; backlight = <&backlight>;
Currently a specific panel number is used in the Elm DTSI, which is corresponded to a 12" panel. However, according to the official Chrome OS devices document, Elm refers to Acer Chromebook R13, which, as the name specifies, uses a 13.3" panel, which comes with EDID information. As the kernel currently prioritizes the hardcoded timing parameters matched with the panel number compatible, a wrong timing will be applied to the 13.3" panel on Acer Chromebook R13, which leads to blank display. Because the Elm DTSI is shared with Hana board, and Hana corresponds to multiple devices from 11" to 14", a certain panel model number shouldn't be present, and driving the panel according to its EDID information is necessary. Signed-off-by: Icenowy Zheng <uwu@icenowy.me> --- arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)