diff mbox series

drm/hyperv: Fix a compilation issue because of not including screen_info.h

Message ID 20230709100514.703759-1-suijingfeng@loongson.cn (mailing list archive)
State New, archived
Headers show
Series drm/hyperv: Fix a compilation issue because of not including screen_info.h | expand

Commit Message

Sui Jingfeng July 9, 2023, 10:05 a.m. UTC 
drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use in this function)
    1033 |                 base = screen_info.lfb_base;
         |                        ^~~~~~~~~~~
   drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported only once for each function it appears in
--
   drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared (first use in this function)
      75 |         drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
         |                                                      ^~~~~~~~~~~
   drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is reported only once for each function it appears in

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/
Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Zimmermann July 9, 2023, 2:31 p.m. UTC | #1 
Hi

Am 09.07.23 um 12:05 schrieb Sui Jingfeng:
>     drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use in this function)
>      1033 |                 base = screen_info.lfb_base;
>           |                        ^~~~~~~~~~~
>     drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported only once for each function it appears in
> --
>     drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared (first use in this function)
>        75 |         drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
>           |                                                      ^~~~~~~~~~~
>     drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is reported only once for each function it appears in
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/
> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks for the patch.

Best regards
Thomas


> ---
>   drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> index a7d2c92d6c6a..8026118c6e03 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> @@ -7,6 +7,7 @@
>   #include <linux/hyperv.h>
>   #include <linux/module.h>
>   #include <linux/pci.h>
> +#include <linux/screen_info.h>
>   
>   #include <drm/drm_aperture.h>
>   #include <drm/drm_atomic_helper.h>
Michael Kelley (LINUX) July 10, 2023, 5:20 a.m. UTC | #2 
From: Sui Jingfeng <suijingfeng@loongson.cn> Sent: Sunday, July 9, 2023 3:05 AM
> 
>    drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
> >> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use
> in this function)
>     1033 |                 base = screen_info.lfb_base;
>          |                        ^~~~~~~~~~~
>    drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported
> only once for each function it appears in
> --
>    drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
> >> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared
> (first use in this function)
>       75 |         drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
>          |                                                      ^~~~~~~~~~~
>    drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is
> reported only once for each function it appears in
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/
> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
>  drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> index a7d2c92d6c6a..8026118c6e03 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> @@ -7,6 +7,7 @@
>  #include <linux/hyperv.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
> +#include <linux/screen_info.h>
> 
>  #include <drm/drm_aperture.h>
>  #include <drm/drm_atomic_helper.h>
> --
> 2.25.1

Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Sui Jingfeng July 10, 2023, 6:34 a.m. UTC | #3 
OK, thanks a lot,

done!

On 2023/7/10 13:20, Michael Kelley (LINUX) wrote:
> From: Sui Jingfeng <suijingfeng@loongson.cn> Sent: Sunday, July 9, 2023 3:05 AM
>>     drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>>>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use
>> in this function)
>>      1033 |                 base = screen_info.lfb_base;
>>           |                        ^~~~~~~~~~~
>>     drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported
>> only once for each function it appears in
>> --
>>     drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>>>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared
>> (first use in this function)
>>        75 |         drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
>>           |                                                      ^~~~~~~~~~~
>>     drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is
>> reported only once for each function it appears in
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/
>> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
>> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
>>   drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> index a7d2c92d6c6a..8026118c6e03 100644
>> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> @@ -7,6 +7,7 @@
>>   #include <linux/hyperv.h>
>>   #include <linux/module.h>
>>   #include <linux/pci.h>
>> +#include <linux/screen_info.h>
>>
>>   #include <drm/drm_aperture.h>
>>   #include <drm/drm_atomic_helper.h>
>> --
>> 2.25.1
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index a7d2c92d6c6a..8026118c6e03 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -7,6 +7,7 @@ 
 #include <linux/hyperv.h>
 #include <linux/module.h>
 #include <linux/pci.h>
+#include <linux/screen_info.h>
 
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>