From patchwork Fri Jul 14 18:06:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos Eduardo Gallo Filho X-Patchwork-Id: 13314137 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7331AC001B0 for ; Fri, 14 Jul 2023 18:08:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B7FC10E8D3; Fri, 14 Jul 2023 18:08:53 +0000 (UTC) Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A65D10E8D2 for ; Fri, 14 Jul 2023 18:08:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 01A5940B42; Fri, 14 Jul 2023 20:08:48 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nFB0oipgnOCk; Fri, 14 Jul 2023 20:08:46 +0200 (CEST) From: Carlos Eduardo Gallo Filho DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1689358126; bh=kpryaEClraU066T2dbISwNctGwV1TRNDGalAYs3XCFw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=g9s3K3glvTNWEmqmlvbQYY4wulTg9mLRXm324OcxNchEWt2rcvIbF9zRc83Wl8mDi Vi/WUVimrQd3No9i/9WAafsNELvE0rk+u9v5qUdEfJefiwQqiHKlRT1+UDiWV3jucm ZRkSEyWUs8UidsiRDSbv56O/ecMoCJtF1WZjz8Qxz+k6n4lck+bQQl/7P0ZEmmcean 0r/34KiOg0MtKZTxYUIakA2maVhuODx7zcGDwp/iuJ+wrCYi/wl5/vYUbbBU93pdYj hPzwbumPZgVlBiVurWbE+TUhQyiRWw4Gv+qCcWJyDeDJYJM/oQOlhjWOv1q1KsuFH0 vjoZyOxc8id6g== To: dri-devel@lists.freedesktop.org Subject: [PATCH 4/4] drm/tests: Add test case for drm_internal_framebuffer_create() Date: Fri, 14 Jul 2023 15:06:19 -0300 Message-ID: <20230714180619.15850-5-gcarlos@disroot.org> In-Reply-To: <20230714180619.15850-1-gcarlos@disroot.org> References: <20230714180619.15850-1-gcarlos@disroot.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrealmeid@igalia.com, tzimmermann@suse.de, tales.aparecida@gmail.com, mripard@kernel.org, mairacanal@riseup.net, Carlos Eduardo Gallo Filho , davidgow@google.com, michal.winiarski@intel.com, arthurgrillo@riseup.net Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Introduce a test to cover the creation of a framebuffer with a setted modifier and a driver that don't support modifiers. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 21 ++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c index 1fbb534b2e22..7ee595321462 100644 --- a/drivers/gpu/drm/tests/drm_framebuffer_test.c +++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c @@ -388,6 +388,26 @@ static void drm_framebuffer_test_to_desc(const struct drm_framebuffer_test *t, c KUNIT_ARRAY_PARAM(drm_framebuffer_create, drm_framebuffer_create_cases, drm_framebuffer_test_to_desc); +static void drm_test_framebuffer_modifiers_not_supported(struct kunit *test) +{ + struct drm_mode_fb_cmd2 cmd = { + .width = MAX_WIDTH, .height = MAX_HEIGHT, + .pixel_format = DRM_FORMAT_ABGR8888, .handles = { 1, 0, 0 }, + .offsets = { UINT_MAX / 2, 0, 0 }, .pitches = { 4 * MAX_WIDTH, 0, 0 }, + .flags = DRM_MODE_FB_MODIFIERS, + }; + struct drm_device *mock = test->priv; + int buffer_created = 0; + + mock->dev_private = &buffer_created; + mock->mode_config.fb_modifiers_not_supported = 1; + + drm_internal_framebuffer_create(mock, &cmd, NULL); + KUNIT_EXPECT_EQ(test, 0, buffer_created); + + mock->mode_config.fb_modifiers_not_supported = 0; +} + struct check_src_coords_case { const int expect; const uint32_t src_x; @@ -494,6 +514,7 @@ KUNIT_ARRAY_PARAM(check_src_coords, check_src_coords_cases, check_src_coords_test_to_desc); static struct kunit_case drm_framebuffer_tests[] = { + KUNIT_CASE(drm_test_framebuffer_modifiers_not_supported), KUNIT_CASE_PARAM(drm_test_framebuffer_create, drm_framebuffer_create_gen_params), KUNIT_CASE_PARAM(drm_test_framebuffer_check_src_coords, check_src_coords_gen_params), { }