diff mbox series

drm/doc: add warning about connector_type_id stability

Message ID 20230717131305.616855-1-contact@emersion.fr (mailing list archive)
State New, archived
Headers show
Series drm/doc: add warning about connector_type_id stability | expand

Commit Message

Simon Ser July 17, 2023, 1:13 p.m. UTC
Mention that the connector_type_id is not stable: it depends on
driver and device probe order.

Signed-off-by: Simon Ser <contact@emersion.fr>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>
---
 include/uapi/drm/drm_mode.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Pekka Paalanen July 17, 2023, 2:01 p.m. UTC | #1
On Mon, 17 Jul 2023 13:13:09 +0000
Simon Ser <contact@emersion.fr> wrote:

> Mention that the connector_type_id is not stable: it depends on
> driver and device probe order.
> 
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Pekka Paalanen <pekka.paalanen@collabora.com>
> ---
>  include/uapi/drm/drm_mode.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index 92d96a2b6763..ea1b639bcb28 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -488,6 +488,9 @@ struct drm_mode_get_connector {
>  	 * This is not an object ID. This is a per-type connector number. Each
>  	 * (type, type_id) combination is unique across all connectors of a DRM
>  	 * device.
> +	 *
> +	 * The (type, type_id) combination is not a stable identifier: the
> +	 * type_id can change depending on the driver probe order.
>  	 */
>  	__u32 connector_type_id;
>  

Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>


Thanks,
pq
diff mbox series

Patch

diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index 92d96a2b6763..ea1b639bcb28 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -488,6 +488,9 @@  struct drm_mode_get_connector {
 	 * This is not an object ID. This is a per-type connector number. Each
 	 * (type, type_id) combination is unique across all connectors of a DRM
 	 * device.
+	 *
+	 * The (type, type_id) combination is not a stable identifier: the
+	 * type_id can change depending on the driver probe order.
 	 */
 	__u32 connector_type_id;