From patchwork Tue Aug 1 23:34:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13337373 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1E23C0015E for ; Tue, 1 Aug 2023 23:35:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 913FB10E45B; Tue, 1 Aug 2023 23:35:32 +0000 (UTC) Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2641410E447 for ; Tue, 1 Aug 2023 23:35:27 +0000 (UTC) Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-790cadee81bso30426839f.0 for ; Tue, 01 Aug 2023 16:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690932926; x=1691537726; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DZ5qQhAi21RhKvxOK+sRufpOvyrXkUuzJS2xfJigOvQ=; b=ByBXycrW3BEzFsp7sn2KxCjuz7b2f4oWMN02MzhCZYsjm9uvpO/s9JnUZ8P4nIQqIk cfnMiaJbotYqRSX1XBk28F5worJqsAVtlo/UlWd8XmQZlAzv/PyK6l2kTpcy8r5MF9Yh DCI8JiWjeLcrikAHzQbB9CHzJeJkgxqh+bVjg0dyvP41PazT/UE59wffT3gyita5WitM iYsjvJ1dd5OgE/G03YRwhtliKV10VqwRcgkRy47MZL6aCPfbmx8ynPi3mNHh3IL8kSej twS/nv2Lxc7bpGi4md4N8czH43WcKBmu2JOzTvIimPEbA8JTC4wFcaBgjJjZU18xgQI+ Gnew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690932926; x=1691537726; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DZ5qQhAi21RhKvxOK+sRufpOvyrXkUuzJS2xfJigOvQ=; b=dDquGCUyzm5k/XHu3qqx9HTBe7bpknAGSO7I0OMOZMyh5mt8Cz5EniAHOJ3fSzH98V iqOmHcmVoj56ipwP3SmxuKvk27YCsUyUecycxSv1PZW+24womNi1hNQEtFtOrq2VTudA ue44D9SXxUXWX3n3ASH9mk41p8KDBqa3o1M95JkkjVq6a7CNhhEwBGfAsEEGxJ1O78Ox 80klcw5uhwmLMqU4Jxly4XIGpaeCupfddMSXSATag6Ltc6WJsjaDvZFkQogBmtf1WmxC SUPYSQSd0lzaBnMsISiWVz9Sbi0MwdxvG3yDMKLYlS4ouPPdg9XBP6CVb/MMXyXzTBI/ Vecw== X-Gm-Message-State: ABy/qLb/7FVBHPoWfAvfnU9iv2A5On2jo5EPVbPiFEAcWE8GgEXz/gTu Pq1q/adzzjomiD0UMJPHR/I= X-Google-Smtp-Source: APBJJlHK4ouJCrRItSLB3LWyyRCf6/aKtJ2jm/wIGL/dLkydEXrmRWM0eP8v6w36zng8+V11ktFjBg== X-Received: by 2002:a05:6e02:218a:b0:346:5a8b:5415 with SMTP id j10-20020a056e02218a00b003465a8b5415mr15429344ila.30.1690932926333; Tue, 01 Aug 2023 16:35:26 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id t13-20020a92ca8d000000b00348d652a6b4sm4157967ilo.48.2023.08.01.16.35.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 16:35:25 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org Subject: [PATCH v5 06/23] dyndbg: split param_set_dyndbg_classes to module/wrapper fns Date: Tue, 1 Aug 2023 17:34:52 -0600 Message-ID: <20230801233515.166971-7-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230801233515.166971-1-jim.cromie@gmail.com> References: <20230801233515.166971-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" rename param_set_dyndbg_classes: add _module_ name & arg, old name is wrapper to new. New arg allows caller to specify that only one module is affected by a prdbgs update. Outer fn preserves kernel_param interface, passing NULL to inner fn. This selectivity will be used later to narrow the scope of changes made. no functional change. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 37 ++++++++++++++++++++++--------------- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index d875c4fa5335..550d380f7690 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -707,18 +707,9 @@ static int param_set_dyndbg_classnames(const char *instr, const struct kernel_pa return 0; } -/** - * param_set_dyndbg_classes - class FOO >control - * @instr: string echo>d to sysfs, input depends on map_type - * @kp: kp->arg has state: bits/lvl, map, map_type - * - * Enable/disable prdbgs by their class, as given in the arguments to - * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative - * levels by bitpos. - * - * Returns: 0 or <0 if error. - */ -int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp) +static int param_set_dyndbg_module_classes(const char *instr, + const struct kernel_param *kp, + const char *modnm) { const struct ddebug_class_param *dcp = kp->arg; const struct ddebug_class_map *map = dcp->map; @@ -755,8 +746,8 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp) KP_NAME(kp), inrep, CLASSMAP_BITMASK(map->length)); inrep &= CLASSMAP_BITMASK(map->length); } - v2pr_info("bits:%lx > %s\n", inrep, KP_NAME(kp)); - totct += ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, NULL); + v2pr_info("bits:0x%lx > %s.%s\n", inrep, modnm ?: "*", KP_NAME(kp)); + totct += ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, modnm); *dcp->bits = inrep; break; case DD_CLASS_TYPE_LEVEL_NUM: @@ -769,7 +760,7 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp) old_bits = CLASSMAP_BITMASK(*dcp->lvl); new_bits = CLASSMAP_BITMASK(inrep); v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); - totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, NULL); + totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, modnm); *dcp->lvl = inrep; break; default: @@ -778,6 +769,22 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp) vpr_info("%s: total matches: %d\n", KP_NAME(kp), totct); return 0; } + +/** + * param_set_dyndbg_classes - class FOO >control + * @instr: string echo>d to sysfs, input depends on map_type + * @kp: kp->arg has state: bits/lvl, map, map_type + * + * Enable/disable prdbgs by their class, as given in the arguments to + * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative + * levels by bitpos. + * + * Returns: 0 or <0 if error. + */ +int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp) +{ + return param_set_dyndbg_module_classes(instr, kp, NULL); +} EXPORT_SYMBOL(param_set_dyndbg_classes); /**