| Message ID | 20230803143358.13563-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] drm/nouveau: remove unused tu102_gr_load() function | expand |
On Thu, Aug 3, 2023 at 4:34 PM Arnd Bergmann <arnd@kernel.org> wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > tu102_gr_load() is completely unused and can be removed to address > this warning: > > drivers/gpu/drm/nouveau/dispnv50/disp.c:2517:1: error: no previous prototype for 'nv50_display_create' > > Another patch was sent in the meantime to mark the function static but > that would just cause a different warning about an unused function. > > Fixes: 1cd97b5490c8 ("drm/nouveau/gr/tu102-: use sw_veid_bundle_init from firmware") > Link: https://lore.kernel.org/all/CACO55tuaNOYphHyB9+ygi9AnXVuF49etsW7x2X5K5iEtFNAAyw@mail.gmail.com/ > Link: https://lore.kernel.org/all/20230417210310.2443152-1-arnd@kernel.org/ > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > I send this one back in April, and Lee Jones sent a similar patch in May. > Please apply so we can enable the warning by default. > --- > drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c > index 3b6c8100a242..a7775aa18541 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c > @@ -206,19 +206,6 @@ tu102_gr_av_to_init_veid(struct nvkm_blob *blob, struct gf100_gr_pack **ppack) > return gk20a_gr_av_to_init_(blob, 64, 0x00100000, ppack); > } > > -int > -tu102_gr_load(struct gf100_gr *gr, int ver, const struct gf100_gr_fwif *fwif) > -{ > - int ret; > - > - ret = gm200_gr_load(gr, ver, fwif); > - if (ret) > - return ret; > - > - return gk20a_gr_load_net(gr, "gr/", "sw_veid_bundle_init", ver, tu102_gr_av_to_init_veid, > - &gr->bundle_veid); > -} > - > static const struct gf100_gr_fwif > tu102_gr_fwif[] = { > { 0, gm200_gr_load, &tu102_gr, &gp108_gr_fecs_acr, &gp108_gr_gpccs_acr }, > -- > 2.39.2 > Reviewed-by: Karol Herbst <kherbst@redhat.com> Will push to drm-misc in a sec
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c index 3b6c8100a242..a7775aa18541 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c @@ -206,19 +206,6 @@ tu102_gr_av_to_init_veid(struct nvkm_blob *blob, struct gf100_gr_pack **ppack) return gk20a_gr_av_to_init_(blob, 64, 0x00100000, ppack); } -int -tu102_gr_load(struct gf100_gr *gr, int ver, const struct gf100_gr_fwif *fwif) -{ - int ret; - - ret = gm200_gr_load(gr, ver, fwif); - if (ret) - return ret; - - return gk20a_gr_load_net(gr, "gr/", "sw_veid_bundle_init", ver, tu102_gr_av_to_init_veid, - &gr->bundle_veid); -} - static const struct gf100_gr_fwif tu102_gr_fwif[] = { { 0, gm200_gr_load, &tu102_gr, &gp108_gr_fecs_acr, &gp108_gr_gpccs_acr },