| Message ID | 20230831080938.47454-3-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Drop ID table and conditionals around of_node pointers | expand |
Hi, On Thu, Aug 31, 2023 at 1:10 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > This patch is based on commit c9e358dfc4a8 ("driver-core: remove > conditionals around devicetree pointers"). > > Having conditional around the of_node pointer of the drm_bridge > structure turns out to make driver code use ugly #ifdef blocks. Drop the > conditionals to simplify drivers. While this slightly increases the size > of struct drm_bridge on non-OF system, the number of bridges used today > and foreseen tomorrow on those systems is very low, so this shouldn't be > an issue. > > So drop #if conditionals by adding struct device_node forward declaration. > > Suggested-by: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > v5->v6: > * Updated commit description. > * Added Rb tag from Douglas Anderson and Laurent > v5: > * Split from patch#2 > * Updated commit description > * Added struct device_node forward declaration. > --- > include/drm/drm_bridge.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I think this has had enough time to marinate, so landed to drm-misc-next: d8dfccde2709 drm/bridge: Drop conditionals around of_node pointers
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index c339fc85fd07..843736627f60 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -32,6 +32,8 @@ #include <drm/drm_mode_object.h> #include <drm/drm_modes.h> +struct device_node; + struct drm_bridge; struct drm_bridge_timings; struct drm_connector; @@ -716,10 +718,8 @@ struct drm_bridge { struct drm_encoder *encoder; /** @chain_node: used to form a bridge chain */ struct list_head chain_node; -#ifdef CONFIG_OF /** @of_node: device node pointer to the bridge */ struct device_node *of_node; -#endif /** @list: to keep track of all added bridges */ struct list_head list; /**
This patch is based on commit c9e358dfc4a8 ("driver-core: remove conditionals around devicetree pointers"). Having conditional around the of_node pointer of the drm_bridge structure turns out to make driver code use ugly #ifdef blocks. Drop the conditionals to simplify drivers. While this slightly increases the size of struct drm_bridge on non-OF system, the number of bridges used today and foreseen tomorrow on those systems is very low, so this shouldn't be an issue. So drop #if conditionals by adding struct device_node forward declaration. Suggested-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- v5->v6: * Updated commit description. * Added Rb tag from Douglas Anderson and Laurent v5: * Split from patch#2 * Updated commit description * Added struct device_node forward declaration. --- include/drm/drm_bridge.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)