| Message ID | 20230913164329.123687-2-mwen@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: improve DTN color state log | expand |
On 9/13/23 10:43, Melissa Wen wrote: > Prepare to hook color state logging according to DCN version. > > Signed-off-by: Melissa Wen <mwen@igalia.com> > --- > .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 27 +++++++++++++------ > 1 file changed, 19 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > index 79befa17bb03..a0c489ed218c 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > @@ -279,19 +279,14 @@ static void dcn10_log_hubp_states(struct dc *dc, void *log_ctx) > DTN_INFO("\n"); > } > > -void dcn10_log_hw_state(struct dc *dc, > - struct dc_log_buffer_ctx *log_ctx) > +static void > +dcn10_log_color_state(struct dc *dc, > + struct dc_log_buffer_ctx *log_ctx) nitpick: put the function definition in a single line. > { > struct dc_context *dc_ctx = dc->ctx; > struct resource_pool *pool = dc->res_pool; > int i; > > - DTN_INFO_BEGIN(); > - > - dcn10_log_hubbub_state(dc, log_ctx); > - > - dcn10_log_hubp_states(dc, log_ctx); > - > DTN_INFO("DPP: IGAM format IGAM mode DGAM mode RGAM mode" > " GAMUT mode C11 C12 C13 C14 C21 C22 C23 C24 " > "C31 C32 C33 C34\n"); > @@ -348,6 +343,22 @@ void dcn10_log_hw_state(struct dc *dc, > s.idle); > } > DTN_INFO("\n"); > +} > + > +void dcn10_log_hw_state(struct dc *dc, > + struct dc_log_buffer_ctx *log_ctx) ditto > +{ > + struct dc_context *dc_ctx = dc->ctx; > + struct resource_pool *pool = dc->res_pool; > + int i; > + > + DTN_INFO_BEGIN(); > + > + dcn10_log_hubbub_state(dc, log_ctx); > + > + dcn10_log_hubp_states(dc, log_ctx); > + > + dcn10_log_color_state(dc, log_ctx); > > DTN_INFO("OTG: v_bs v_be v_ss v_se vpol vmax vmin vmax_sel vmin_sel h_bs h_be h_ss h_se hpol htot vtot underflow blank_en\n"); >
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c index 79befa17bb03..a0c489ed218c 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c @@ -279,19 +279,14 @@ static void dcn10_log_hubp_states(struct dc *dc, void *log_ctx) DTN_INFO("\n"); } -void dcn10_log_hw_state(struct dc *dc, - struct dc_log_buffer_ctx *log_ctx) +static void +dcn10_log_color_state(struct dc *dc, + struct dc_log_buffer_ctx *log_ctx) { struct dc_context *dc_ctx = dc->ctx; struct resource_pool *pool = dc->res_pool; int i; - DTN_INFO_BEGIN(); - - dcn10_log_hubbub_state(dc, log_ctx); - - dcn10_log_hubp_states(dc, log_ctx); - DTN_INFO("DPP: IGAM format IGAM mode DGAM mode RGAM mode" " GAMUT mode C11 C12 C13 C14 C21 C22 C23 C24 " "C31 C32 C33 C34\n"); @@ -348,6 +343,22 @@ void dcn10_log_hw_state(struct dc *dc, s.idle); } DTN_INFO("\n"); +} + +void dcn10_log_hw_state(struct dc *dc, + struct dc_log_buffer_ctx *log_ctx) +{ + struct dc_context *dc_ctx = dc->ctx; + struct resource_pool *pool = dc->res_pool; + int i; + + DTN_INFO_BEGIN(); + + dcn10_log_hubbub_state(dc, log_ctx); + + dcn10_log_hubp_states(dc, log_ctx); + + dcn10_log_color_state(dc, log_ctx); DTN_INFO("OTG: v_bs v_be v_ss v_se vpol vmax vmin vmax_sel vmin_sel h_bs h_be h_ss h_se hpol htot vtot underflow blank_en\n");
Prepare to hook color state logging according to DCN version. Signed-off-by: Melissa Wen <mwen@igalia.com> --- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 27 +++++++++++++------ 1 file changed, 19 insertions(+), 8 deletions(-)