diff mbox series

[3/3] drm/v3d: add brcm,2712-v3d as a compatible V3D device

Message ID 20230928114532.167854-4-itoral@igalia.com (mailing list archive)
State New, archived
Headers show
Series V3D module changes for Pi5 | expand

Commit Message

Iago Toral Sept. 28, 2023, 11:45 a.m. UTC 
---
 drivers/gpu/drm/v3d/v3d_drv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Maíra Canal Sept. 28, 2023, 3:06 p.m. UTC | #1 
Please, add a commit message and your s-o-b.

Apart from that,

Reviewed-by: Maíra Canal <mcanal@igalia.com>

Best Regards,
- Maíra

On 9/28/23 08:45, Iago Toral Quiroga wrote:
> ---
>   drivers/gpu/drm/v3d/v3d_drv.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
> index ffbbe9d527d3..0ed2e7ba8b33 100644
> --- a/drivers/gpu/drm/v3d/v3d_drv.c
> +++ b/drivers/gpu/drm/v3d/v3d_drv.c
> @@ -186,6 +186,7 @@ static const struct drm_driver v3d_drm_driver = {
>   };
>   
>   static const struct of_device_id v3d_of_match[] = {
> +	{ .compatible = "brcm,2712-v3d" },
>   	{ .compatible = "brcm,2711-v3d" },
>   	{ .compatible = "brcm,7268-v3d" },
>   	{ .compatible = "brcm,7278-v3d" },
Stefan Wahren Sept. 29, 2023, 5:34 a.m. UTC | #2 
Hi Iago,

additional to Maria's comments:

Please keep the order of the compatible strings.

Also you need to update the device tree binding before this patch:
Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml

Also make sure that the series is send to the maintainers, not just
dri-devel by using scripts/get_maintainer.pl

Best regards
diff mbox series

Patch

diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index ffbbe9d527d3..0ed2e7ba8b33 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -186,6 +186,7 @@  static const struct drm_driver v3d_drm_driver = {
 };
 
 static const struct of_device_id v3d_of_match[] = {
+	{ .compatible = "brcm,2712-v3d" },
 	{ .compatible = "brcm,2711-v3d" },
 	{ .compatible = "brcm,7268-v3d" },
 	{ .compatible = "brcm,7278-v3d" },