diff mbox series

[1/3] drm/virtio: use uint64_t more in virtio_gpu_context_init_ioctl

Message ID 20231016184200.639-1-gurchetansingh@chromium.org (mailing list archive)
State New, archived
Headers show
Series [1/3] drm/virtio: use uint64_t more in virtio_gpu_context_init_ioctl | expand

Commit Message

Gurchetan Singh Oct. 16, 2023, 6:41 p.m. UTC 
drm_virtgpu_context_set_param defines both param and
value to be u64s.

Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
---
 drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Josh Simonot Oct. 16, 2023, 8:10 p.m. UTC | #1 
Reviewed-by: Josh Simonot <josh.simonot at gmail.com>


On Mon, 16 Oct 2023 at 14:42, Gurchetan Singh <gurchetansingh@chromium.org>
wrote:

> drm_virtgpu_context_set_param defines both param and
> value to be u64s.
>
> Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
> ---
>  drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> index b24b11f25197..8d13b17c215b 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> @@ -565,8 +565,8 @@ static int virtio_gpu_context_init_ioctl(struct
> drm_device *dev,
>                                          void *data, struct drm_file *file)
>  {
>         int ret = 0;
> -       uint32_t num_params, i, param, value;
> -       uint64_t valid_ring_mask;
> +       uint32_t num_params, i;
> +       uint64_t valid_ring_mask, param, value;
>         size_t len;
>         struct drm_virtgpu_context_set_param *ctx_set_params = NULL;
>         struct virtio_gpu_device *vgdev = dev->dev_private;
> --
> 2.42.0.655.g421f12c284-goog
>
>
Dmitry Osipenko Oct. 16, 2023, 8:43 p.m. UTC | #2 
On 10/16/23 21:41, Gurchetan Singh wrote:
> drm_virtgpu_context_set_param defines both param and
> value to be u64s.
> 
> Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
> ---
>  drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> index b24b11f25197..8d13b17c215b 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> @@ -565,8 +565,8 @@ static int virtio_gpu_context_init_ioctl(struct drm_device *dev,
>  					 void *data, struct drm_file *file)
>  {
>  	int ret = 0;
> -	uint32_t num_params, i, param, value;
> -	uint64_t valid_ring_mask;
> +	uint32_t num_params, i;
> +	uint64_t valid_ring_mask, param, value;
>  	size_t len;
>  	struct drm_virtgpu_context_set_param *ctx_set_params = NULL;
>  	struct virtio_gpu_device *vgdev = dev->dev_private;

Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
index b24b11f25197..8d13b17c215b 100644
--- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
+++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
@@ -565,8 +565,8 @@  static int virtio_gpu_context_init_ioctl(struct drm_device *dev,
 					 void *data, struct drm_file *file)
 {
 	int ret = 0;
-	uint32_t num_params, i, param, value;
-	uint64_t valid_ring_mask;
+	uint32_t num_params, i;
+	uint64_t valid_ring_mask, param, value;
 	size_t len;
 	struct drm_virtgpu_context_set_param *ctx_set_params = NULL;
 	struct virtio_gpu_device *vgdev = dev->dev_private;