| Message ID | 20231110175854.40ee0629@endymion.delvare (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Dependencies of DRM_LOONGSON | expand |
Hi, On 2023/11/11 00:58, Jean Delvare wrote: > Hi Jingfeng, > > You recently added the loongson drm driver to the Linux kernel tree. > Unlike all other loongson drivers, the drm driver doesn't have any > dependency set on the platform or architecture, and is therefore > proposed on all architectures. As far as I understand, this driver is > only useful on Loongson-based MIPS systems, therefore I believe it > should only be offered as an option on these systems. Yes, you are right for now. Thanks a lot for pointed out. But it is also usable on LoongArch[1] systems. [1] https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html > Would the following change be OK with you? "depends on LOONGARCH || MIPS || COMPILE_TEST" should be enough, so please update the patch and resend, thanks a lot. :-) > From: Jean Delvare <jdelvare@suse.de> > Subject: drm/loongson: Add platform dependency > > Only offer the Loongson DRM driver as an option on platforms where > it makes sense. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > --- > drivers/gpu/drm/loongson/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-6.6.orig/drivers/gpu/drm/loongson/Kconfig > +++ linux-6.6/drivers/gpu/drm/loongson/Kconfig > @@ -3,6 +3,7 @@ > config DRM_LOONGSON > tristate "DRM support for Loongson Graphics" > depends on DRM && PCI && MMU > + depends on MACH_LOONGSON32 || MACH_LOONGSON64 || COMPILE_TEST depends on LOONGARCH || MIPS || COMPILE_TEST > select DRM_KMS_HELPER > select DRM_TTM > select I2C > > Thanks,
--- linux-6.6.orig/drivers/gpu/drm/loongson/Kconfig +++ linux-6.6/drivers/gpu/drm/loongson/Kconfig @@ -3,6 +3,7 @@ config DRM_LOONGSON tristate "DRM support for Loongson Graphics" depends on DRM && PCI && MMU + depends on MACH_LOONGSON32 || MACH_LOONGSON64 || COMPILE_TEST select DRM_KMS_HELPER select DRM_TTM select I2C