| Message ID | 20231113085457.199053-2-tvrtko.ursulin@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/i915: Remove return type from i915_drm_client_remove_object | expand |
On Mon, 13 Nov 2023, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > __rcu annotation is needed to avoid the sparse warnings such as: > > .../i915_drm_client.c:92:9: sparse: sparse: incompatible types in comparison expression (different address spaces): > .../i915_drm_client.c:92:9: sparse: struct list_head [noderef] __rcu * > .../i915_drm_client.c:92:9: sparse: struct list_head * > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Fixes: 968853033d8a ("drm/i915: Implement fdinfo memory stats printing") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202311110610.h0m6ydI5-lkp@intel.com/ > Cc: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/i915_drm_client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c > index be9acfd9410e..fa6852713bee 100644 > --- a/drivers/gpu/drm/i915/i915_drm_client.c > +++ b/drivers/gpu/drm/i915/i915_drm_client.c > @@ -78,7 +78,7 @@ static void show_meminfo(struct drm_printer *p, struct drm_file *file) > struct drm_i915_private *i915 = fpriv->i915; > struct drm_i915_gem_object *obj; > struct intel_memory_region *mr; > - struct list_head *pos; > + struct list_head __rcu *pos; > unsigned int id; > > /* Public objects. */
Hi Tvrtko, On Mon, Nov 13, 2023 at 08:54:57AM +0000, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > __rcu annotation is needed to avoid the sparse warnings such as: > > .../i915_drm_client.c:92:9: sparse: sparse: incompatible types in comparison expression (different address spaces): > .../i915_drm_client.c:92:9: sparse: struct list_head [noderef] __rcu * > .../i915_drm_client.c:92:9: sparse: struct list_head * > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Fixes: 968853033d8a ("drm/i915: Implement fdinfo memory stats printing") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202311110610.h0m6ydI5-lkp@intel.com/ > Cc: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, Andi
diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c index be9acfd9410e..fa6852713bee 100644 --- a/drivers/gpu/drm/i915/i915_drm_client.c +++ b/drivers/gpu/drm/i915/i915_drm_client.c @@ -78,7 +78,7 @@ static void show_meminfo(struct drm_printer *p, struct drm_file *file) struct drm_i915_private *i915 = fpriv->i915; struct drm_i915_gem_object *obj; struct intel_memory_region *mr; - struct list_head *pos; + struct list_head __rcu *pos; unsigned int id; /* Public objects. */