From patchwork Wed Nov 15 15:26:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Morgan X-Patchwork-Id: 13456943 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9086EC54FB9 for ; Wed, 15 Nov 2023 15:27:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 18C5010E060; Wed, 15 Nov 2023 15:27:03 +0000 (UTC) Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3806D10E059 for ; Wed, 15 Nov 2023 15:26:54 +0000 (UTC) Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-581ed744114so3168650eaf.0 for ; Wed, 15 Nov 2023 07:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700062013; x=1700666813; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KZGFsZil0baYKKqeLGbbmIrruY0ps4D1rKYDPh+vV2g=; b=NVLj7FOQxbHfJ1n6sCQpxdiL6KOos9xSrAjpuQUbN2SXTXWCWImPDFSxw4g6H2tqbp nvgj1HZfEFrORYXsD9qBKoeV0oa4xKT+UrMPT+R3o37CiMF7y9fbvlEpaCAUhVfpbOYN a0/1nHZHJGtmMM58LooqPO396x6EcQ6xcKugJfHFvJ3jWyzaw18snKO90XnNODWOfspq RgQ6thdO0biNsRl6dEliZfIChAeTZ/r5W8yJh+nANWi8pVDPXSf2alvJlAXaG5bOdYmT 2kS/5yFP27npALbrXGlz83734oXnicd4NP57ez0kKkuvAgbfnW9C0a+ZECTCXAXy29Vl YCBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700062013; x=1700666813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KZGFsZil0baYKKqeLGbbmIrruY0ps4D1rKYDPh+vV2g=; b=GT6uqywWEJ7Y0nnzP6s6KLVJ8Y6K2qnwPhWDe01J6FII6Vxrl4GYaEbwjIaA81KgL6 2EFYEQuPhRNwmeNRUstfr8leDo68p7Er2vR72ClbNvK973g8kM+viMDZHmpKjmyiGfKT SUv8cyuXAonEJAm0Aa9tM7a49sLRISErVaw5UTvy9t0GfF9swNGSnBpCQP6+0/Z5e36u tiRbnlyCbnPdfQ1YqD7YdvR/iGu7KiEuoEjuuYt4GtCVcEvXnb8R0v8HIFUfvTv5MnrJ pxzvBdu69QQIVMu4F2imw+cR0p0WNdY5MqdgeiiIM5NVk8fTh8vOV4PzNXWxrZWLuGO5 Lraw== X-Gm-Message-State: AOJu0YyK6GKZLRzfZ5aKBtj4svP5tXopnoNxweIJLf4W7voYXBPB51Rj NznUQTkyFArpUC6ClKuQzyvhlnMirhM= X-Google-Smtp-Source: AGHT+IHYrxG2w1/cHskJG3vTQP4FMyX6nm01gaV4IGT/y9/Nm4/afRw3q1CqHTi2fBEJPEQhVv9eYA== X-Received: by 2002:a4a:7505:0:b0:581:d5a6:da4a with SMTP id j5-20020a4a7505000000b00581d5a6da4amr10251799ooc.1.1700062013294; Wed, 15 Nov 2023 07:26:53 -0800 (PST) Received: from localhost.localdomain ([75.28.21.198]) by smtp.gmail.com with ESMTPSA id a18-20020a056830101200b006cdf9935af2sm398012otp.53.2023.11.15.07.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 07:26:52 -0800 (PST) From: Chris Morgan To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/4] drm/panel-elida-kd35t133: hold panel in reset for unprepare Date: Wed, 15 Nov 2023 09:26:45 -0600 Message-Id: <20231115152647.2303283-3-macroalpha82@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231115152647.2303283-1-macroalpha82@gmail.com> References: <20231115152647.2303283-1-macroalpha82@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_jesszhan@quicinc.com, sam@ravnborg.org, Chris Morgan , neil.armstrong@linaro.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Chris Morgan For devices like the Anbernic RG351M and RG351P the panel is wired to an always on regulator. When the device suspends and wakes up, there are some slight artifacts on the screen that go away over time. If instead we hold the panel in reset status after it is unprepared, this does not happen. Signed-off-by: Chris Morgan Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c b/drivers/gpu/drm/panel/panel-elida-kd35t133.c index 6cd8536c09ff..f1fc4a26f447 100644 --- a/drivers/gpu/drm/panel/panel-elida-kd35t133.c +++ b/drivers/gpu/drm/panel/panel-elida-kd35t133.c @@ -104,6 +104,8 @@ static int kd35t133_unprepare(struct drm_panel *panel) return ret; } + gpiod_set_value_cansleep(ctx->reset_gpio, 1); + regulator_disable(ctx->iovcc); regulator_disable(ctx->vdd);