diff mbox series

[v5,01/32] drm/drm_mode_object: increase max objects to accommodate new color props

Message ID 20231116195812.906115-2-mwen@igalia.com (mailing list archive)
State New, archived
Headers show
Series drm/amd/display: add AMD driver-specific properties for color mgmt | expand

Commit Message

Melissa Wen Nov. 16, 2023, 7:57 p.m. UTC
DRM_OBJECT_MAX_PROPERTY limits the number of properties to be attached
and we are increasing that value all time we add a new property (generic
or driver-specific).

In this series, we are adding 13 new KMS driver-specific properties for
AMD color manage:
- CRTC Gamma enumerated Transfer Function
- Plane: Degamma LUT+size+TF, HDR multiplier, shaper LUT+size+TF, 3D
  LUT+size, blend LUT+size+TF (12)

Therefore, just increase DRM_OBJECT_MAX_PROPERTY to a number (64) that
accomodates these new properties and gives some room for others,
avoiding change this number everytime we add a new KMS property.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Simon Ser <contact@emersion.fr>
Signed-off-by: Melissa Wen <mwen@igalia.com>
---
 include/drm/drm_mode_object.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Abhinav Kumar Nov. 16, 2023, 10:15 p.m. UTC | #1
On 11/16/2023 11:57 AM, Melissa Wen wrote:
> DRM_OBJECT_MAX_PROPERTY limits the number of properties to be attached
> and we are increasing that value all time we add a new property (generic
> or driver-specific).
> 
> In this series, we are adding 13 new KMS driver-specific properties for
> AMD color manage:
> - CRTC Gamma enumerated Transfer Function
> - Plane: Degamma LUT+size+TF, HDR multiplier, shaper LUT+size+TF, 3D
>    LUT+size, blend LUT+size+TF (12)
> 
> Therefore, just increase DRM_OBJECT_MAX_PROPERTY to a number (64) that
> accomodates these new properties and gives some room for others,
> avoiding change this number everytime we add a new KMS property.
> 
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
> Reviewed-by: Simon Ser <contact@emersion.fr>
> Signed-off-by: Melissa Wen <mwen@igalia.com>


Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>


> ---
>   include/drm/drm_mode_object.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_mode_object.h b/include/drm/drm_mode_object.h
> index 912f1e415685..08d7a7f0188f 100644
> --- a/include/drm/drm_mode_object.h
> +++ b/include/drm/drm_mode_object.h
> @@ -60,7 +60,7 @@ struct drm_mode_object {
>   	void (*free_cb)(struct kref *kref);
>   };
>   
> -#define DRM_OBJECT_MAX_PROPERTY 24
> +#define DRM_OBJECT_MAX_PROPERTY 64
>   /**
>    * struct drm_object_properties - property tracking for &drm_mode_object
>    */
diff mbox series

Patch

diff --git a/include/drm/drm_mode_object.h b/include/drm/drm_mode_object.h
index 912f1e415685..08d7a7f0188f 100644
--- a/include/drm/drm_mode_object.h
+++ b/include/drm/drm_mode_object.h
@@ -60,7 +60,7 @@  struct drm_mode_object {
 	void (*free_cb)(struct kref *kref);
 };
 
-#define DRM_OBJECT_MAX_PROPERTY 24
+#define DRM_OBJECT_MAX_PROPERTY 64
 /**
  * struct drm_object_properties - property tracking for &drm_mode_object
  */