| Message ID | 20231130-sc8180x-dpu-safe-lut-v1-1-a8a6bbac36b8@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/msm/dpu: Add missing safe_lut_tbl in sc8180x catalog | expand |
On Thu, Nov 30, 2023 at 04:35:01PM -0800, Bjorn Andersson wrote: > Similar to SC8280XP, the misconfigured SAFE logic causes rather > significant delays in __arm_smmu_tlb_sync(), resulting in poor > performance for things such as USB. > > Introduce appropriate SAFE values for SC8180X to correct this. > > Fixes: f3af2d6ee9ab ("drm/msm/dpu: Add SC8180x to hw catalog") Reported-by: Anton Bambura <jenneron@postmarketos.org> > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h > index e07f4c8c25b9..9ffc8804a6fc 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h > @@ -367,6 +367,7 @@ static const struct dpu_perf_cfg sc8180x_perf_data = { > .min_llcc_ib = 800000, > .min_dram_ib = 800000, > .danger_lut_tbl = {0xf, 0xffff, 0x0}, > + .safe_lut_tbl = {0xfff0, 0xf000, 0xffff}, > .qos_lut_tbl = { > {.nentry = ARRAY_SIZE(sc7180_qos_linear), > .entries = sc7180_qos_linear > > --- > base-commit: 3cd3fe06ff81cfb3a969acb12a56796cff5af23d > change-id: 20231130-sc8180x-dpu-safe-lut-ffd0df221d67 > > Best regards, > -- > Bjorn Andersson <quic_bjorande@quicinc.com> >
On Thu, Nov 30, 2023 at 04:35:01PM -0800, Bjorn Andersson wrote: > Similar to SC8280XP, the misconfigured SAFE logic causes rather > significant delays in __arm_smmu_tlb_sync(), resulting in poor > performance for things such as USB. > > Introduce appropriate SAFE values for SC8180X to correct this. > > Fixes: f3af2d6ee9ab ("drm/msm/dpu: Add SC8180x to hw catalog") Missing CC stable tag? > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> Johan
On Fri, Dec 01, 2023 at 09:06:45AM +0100, Johan Hovold wrote: > On Thu, Nov 30, 2023 at 04:35:01PM -0800, Bjorn Andersson wrote: > > Similar to SC8280XP, the misconfigured SAFE logic causes rather > > significant delays in __arm_smmu_tlb_sync(), resulting in poor > > performance for things such as USB. > > > > Introduce appropriate SAFE values for SC8180X to correct this. > > > > Fixes: f3af2d6ee9ab ("drm/msm/dpu: Add SC8180x to hw catalog") > > Missing CC stable tag? > I figured it doesn't matter in practice, there's still a few issues left preventing people from just running a stable kernel on this platform. But it would be the right thing to do... Cc: stable@vger.kernel.org Regards, Bjorn > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > > Johan >
On 01/12/2023 02:35, Bjorn Andersson wrote: > Similar to SC8280XP, the misconfigured SAFE logic causes rather > significant delays in __arm_smmu_tlb_sync(), resulting in poor > performance for things such as USB. > > Introduce appropriate SAFE values for SC8180X to correct this. > > Fixes: f3af2d6ee9ab ("drm/msm/dpu: Add SC8180x to hw catalog") > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Thu, 30 Nov 2023 16:35:01 -0800, Bjorn Andersson wrote: > Similar to SC8280XP, the misconfigured SAFE logic causes rather > significant delays in __arm_smmu_tlb_sync(), resulting in poor > performance for things such as USB. > > Introduce appropriate SAFE values for SC8180X to correct this. > > > [...] Applied, thanks! [1/1] drm/msm/dpu: Add missing safe_lut_tbl in sc8180x catalog https://gitlab.freedesktop.org/lumag/msm/-/commit/7cc2621f16b6 Best regards,
diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h index e07f4c8c25b9..9ffc8804a6fc 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h @@ -367,6 +367,7 @@ static const struct dpu_perf_cfg sc8180x_perf_data = { .min_llcc_ib = 800000, .min_dram_ib = 800000, .danger_lut_tbl = {0xf, 0xffff, 0x0}, + .safe_lut_tbl = {0xfff0, 0xf000, 0xffff}, .qos_lut_tbl = { {.nentry = ARRAY_SIZE(sc7180_qos_linear), .entries = sc7180_qos_linear
Similar to SC8280XP, the misconfigured SAFE logic causes rather significant delays in __arm_smmu_tlb_sync(), resulting in poor performance for things such as USB. Introduce appropriate SAFE values for SC8180X to correct this. Fixes: f3af2d6ee9ab ("drm/msm/dpu: Add SC8180x to hw catalog") Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 1 + 1 file changed, 1 insertion(+) --- base-commit: 3cd3fe06ff81cfb3a969acb12a56796cff5af23d change-id: 20231130-sc8180x-dpu-safe-lut-ffd0df221d67 Best regards,