| Message ID | 20231212195754.232303-1-bmasney@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fbdev/simplefb: change loglevel when the power domains cannot be parsed | expand |
On Tue, Dec 12, 2023 at 02:57:54PM -0500, Brian Masney wrote: > When the power domains cannot be parsed, the message is incorrectly > logged as an info message. Let's change this to an error since an error > is returned. > > Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains") > Signed-off-by: Brian Masney <bmasney@redhat.com> Acked-by: Andrew Halaney <ahalaney@redhat.com> > --- > drivers/video/fbdev/simplefb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c > index 6f58ee276ad1..028a56525047 100644 > --- a/drivers/video/fbdev/simplefb.c > +++ b/drivers/video/fbdev/simplefb.c > @@ -470,7 +470,7 @@ static int simplefb_attach_genpds(struct simplefb_par *par, > if (err == -ENOENT) > return 0; > > - dev_info(dev, "failed to parse power-domains: %d\n", err); > + dev_err(dev, "failed to parse power-domains: %d\n", err); > return err; > } > > -- > 2.43.0 >
Brian Masney <bmasney@redhat.com> writes: Hello Brian, > When the power domains cannot be parsed, the message is incorrectly > logged as an info message. Let's change this to an error since an error > is returned. > > Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains") > Signed-off-by: Brian Masney <bmasney@redhat.com> > --- > drivers/video/fbdev/simplefb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c > index 6f58ee276ad1..028a56525047 100644 > --- a/drivers/video/fbdev/simplefb.c > +++ b/drivers/video/fbdev/simplefb.c > @@ -470,7 +470,7 @@ static int simplefb_attach_genpds(struct simplefb_par *par, > if (err == -ENOENT) > return 0; > > - dev_info(dev, "failed to parse power-domains: %d\n", err); > + dev_err(dev, "failed to parse power-domains: %d\n", err); > return err; > } > Makes sense to me. Acked-by: Javier Martinez Canillas <javierm@redhat.com>
On Tue, Dec 12, 2023 at 02:57:54PM -0500, Brian Masney wrote: > When the power domains cannot be parsed, the message is incorrectly > logged as an info message. Let's change this to an error since an error > is returned. > > Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains") > Signed-off-by: Brian Masney <bmasney@redhat.com> > --- > drivers/video/fbdev/simplefb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding <treding@nvidia.com>
Hi, On 12/12/23 20:57, Brian Masney wrote: > When the power domains cannot be parsed, the message is incorrectly > logged as an info message. Let's change this to an error since an error > is returned. > > Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains") > Signed-off-by: Brian Masney <bmasney@redhat.com> Thank you for your patch. I have pushed this to drm-misc-next now. Regards, Hans > --- > drivers/video/fbdev/simplefb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c > index 6f58ee276ad1..028a56525047 100644 > --- a/drivers/video/fbdev/simplefb.c > +++ b/drivers/video/fbdev/simplefb.c > @@ -470,7 +470,7 @@ static int simplefb_attach_genpds(struct simplefb_par *par, > if (err == -ENOENT) > return 0; > > - dev_info(dev, "failed to parse power-domains: %d\n", err); > + dev_err(dev, "failed to parse power-domains: %d\n", err); > return err; > } >
diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index 6f58ee276ad1..028a56525047 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -470,7 +470,7 @@ static int simplefb_attach_genpds(struct simplefb_par *par, if (err == -ENOENT) return 0; - dev_info(dev, "failed to parse power-domains: %d\n", err); + dev_err(dev, "failed to parse power-domains: %d\n", err); return err; }
When the power domains cannot be parsed, the message is incorrectly logged as an info message. Let's change this to an error since an error is returned. Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains") Signed-off-by: Brian Masney <bmasney@redhat.com> --- drivers/video/fbdev/simplefb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)