| Message ID | 20231215111129.9559-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mm: Allow CONFIG_DRM_MM_DEBUG with DRM=m | expand |
Ville Syrjala <ville.syrjala@linux.intel.com> writes: Hello Ville, > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > The original rationale for > commit cd456f8d06d2 ("drm: Restrict stackdepot usage to builtin drm.ko") > was that depot_save_stack() (which is what we used back then) > wasn't exported. stack_depot_save() (which is what we use now) is > exported however, so relax the dependency allow CONFIG_DRM_MM_DEBUG > with DRM=m. > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 31cfe2c2a2af..4b8b8f8a0e72 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -42,7 +42,7 @@ config DRM_MIPI_DSI > config DRM_DEBUG_MM > bool "Insert extra checks and debug info into the DRM range managers" > default n > - depends on DRM=y > + depends on DRM > depends on STACKTRACE_SUPPORT > select STACKDEPOT > help > -- Acked-by: Javier Martinez Canillas <javierm@redhat.com>
On Fri, Dec 15, 2023 at 12:34:48PM +0100, Javier Martinez Canillas wrote: > Ville Syrjala <ville.syrjala@linux.intel.com> writes: > > Hello Ville, > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > The original rationale for > > commit cd456f8d06d2 ("drm: Restrict stackdepot usage to builtin drm.ko") > > was that depot_save_stack() (which is what we used back then) > > wasn't exported. stack_depot_save() (which is what we use now) is > > exported however, so relax the dependency allow CONFIG_DRM_MM_DEBUG > > with DRM=m. > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > --- > > drivers/gpu/drm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index 31cfe2c2a2af..4b8b8f8a0e72 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -42,7 +42,7 @@ config DRM_MIPI_DSI > > config DRM_DEBUG_MM > > bool "Insert extra checks and debug info into the DRM range managers" > > default n > > - depends on DRM=y > > + depends on DRM > > depends on STACKTRACE_SUPPORT > > select STACKDEPOT > > help > > -- > > Acked-by: Javier Martinez Canillas <javierm@redhat.com> Thanks. Pushed to drm-misc-next.
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 31cfe2c2a2af..4b8b8f8a0e72 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -42,7 +42,7 @@ config DRM_MIPI_DSI config DRM_DEBUG_MM bool "Insert extra checks and debug info into the DRM range managers" default n - depends on DRM=y + depends on DRM depends on STACKTRACE_SUPPORT select STACKDEPOT help