[V5,1/2] dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI

Commit Message

Adam Ford Jan. 6, 2024, 1:56 a.m. UTC

From: Lucas Stach <[e-mail]>

Add binding for the i.MX8MP HDMI parallel video interface block.

Signed-off-by: Lucas Stach <[e-mail]>
Reviewed-by: Laurent Pinchart <[e-mail]>
Reviewed-by: Conor Dooley <[e-mail]>
---

V5:  I tried to help move this along, so I took Lucas' patch and
     attempted to apply fixes based on feedback.  I don't have
     all the history, so apologies for that.
     Removed the pipe character from the Description.
     Increased the register size from 0x40 to 0x44.

Comments

Fabio Estevam Jan. 6, 2024, 2:29 a.m. UTC | #1

Hi Adam,

Thanks for moving this forward.

On Fri, Jan 5, 2024 at 10:56 PM Adam Ford <[e-mail]> wrote:
>
> From: Lucas Stach <[e-mail]>
>
> Add binding for the i.MX8MP HDMI parallel video interface block.
>
> Signed-off-by: Lucas Stach <[e-mail]>
> Reviewed-by: Laurent Pinchart <[e-mail]>
> Reviewed-by: Conor Dooley <[e-mail]>

You missed your own Signed-off-by tag.

Uwe Kleine-König Jan. 6, 2024, 12:45 p.m. UTC | #2

Hello Adam,

On Fri, Jan 05, 2024 at 07:56:21PM -0600, Adam Ford wrote:
> From: Lucas Stach <[e-mail]>
> 
> Add binding for the i.MX8MP HDMI parallel video interface block.
> 
> Signed-off-by: Lucas Stach <[e-mail]>
> Reviewed-by: Laurent Pinchart <[e-mail]>
> Reviewed-by: Conor Dooley <[e-mail]>

Without looking at the patch's content: This lacks a Signed-off line by
you.

Best regards
Uwe

Patch

diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml
new file mode 100644
index 000000000000..3377f152f319
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml
@@ -0,0 +1,83 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/imx/fsl,imx8mp-hdmi-pvi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale i.MX8MP HDMI Parallel Video Interface
+
+maintainers:
+  - Lucas Stach <[e-mail]>
+
+description:
+  The HDMI parallel video interface is a timing and sync generator block in the
+  i.MX8MP SoC, that sits between the video source and the HDMI TX controller.
+
+properties:
+  compatible:
+    const: fsl,imx8mp-hdmi-pvi
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  power-domains:
+    maxItems: 1
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+
+    properties:
+      port@0:
+        $ref: /schemas/graph.yaml#/properties/port
+        description: Input from the LCDIF controller.
+
+      port@1:
+        $ref: /schemas/graph.yaml#/properties/port
+        description: Output to the HDMI TX controller.
+
+    required:
+      - port@0
+      - port@1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - power-domains
+  - ports
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/power/imx8mp-power.h>
+
+    display-bridge@32fc4000 {
+        compatible = "fsl,imx8mp-hdmi-pvi";
+        reg = <0x32fc4000 0x44>;
+        interrupts = <12 IRQ_TYPE_LEVEL_HIGH>;
+        power-domains = <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_PVI>;
+
+        ports {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            port@0 {
+                reg = <0>;
+                pvi_from_lcdif3: endpoint {
+                    remote-endpoint = <&lcdif3_to_pvi>;
+                };
+            };
+
+            port@1 {
+                reg = <1>;
+                pvi_to_hdmi_tx: endpoint {
+                    remote-endpoint = <&hdmi_tx_from_pvi>;
+                };
+            };
+        };
+    };