From patchwork Tue Jan 9 10:43:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacek Lawrynowicz X-Patchwork-Id: 13514748 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CBABC46CD2 for ; Tue, 9 Jan 2024 10:43:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF3F010E3C8; Tue, 9 Jan 2024 10:43:11 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A307310E3C8 for ; Tue, 9 Jan 2024 10:43:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704796989; x=1736332989; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=cunvqZosYtlZDsjYVMrAh+nwU3Mm3Tb/yaII408psYU=; b=VZXoq9hNhFo50AYyB7jUEJWkMoyvH+Kq8e6Qrb0/Ml8ANDv/yereSEUJ SdVWaHU+VNn+F8JfiIFOJ5FS9cSxKswrfEDk7P4r2zry9Rm8yr6sLmu0g wFArJtZnwsHZ7DWmuYhSqHP0RLjLJiPJZuJ7yNHYg5DQwE3mZAlvG0Q7y myUywyLQ9DMSqmw0DTECPV77iQ4PSn3EUWWm8Rcus4ikQhfM2bnmdavkT f0cm1nQR67htQ1e/VM+El8/CjvHBuHzyS33vgYGKKiNQNl3E0/yyjh+uZ L3tamZqRpAxDUWYkj9O27ADIATzUTUyHRjiUyI1RcXGtWMnFGqIvwYzsw w==; X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="462437272" X-IronPort-AV: E=Sophos;i="6.04,182,1695711600"; d="scan'208";a="462437272" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 02:43:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="852136413" X-IronPort-AV: E=Sophos;i="6.04,182,1695711600"; d="scan'208";a="852136413" Received: from jlawryno.igk.intel.com ([10.91.220.59]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 02:43:07 -0800 From: Jacek Lawrynowicz To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/shmem-helper: Fix comment describing dma-buf mappings Date: Tue, 9 Jan 2024 11:43:05 +0100 Message-ID: <20240109104305.604549-1-jacek.lawrynowicz@linux.intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tzimmermann@suse.de, mripard@kernel.org, Jacek Lawrynowicz Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" `shmem->map_wc was` set to `false` but the comment suggested WC was enabled for imported buffers. Signed-off-by: Jacek Lawrynowicz --- drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index e435f986cd13..1532f1766170 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -75,7 +75,7 @@ __drm_gem_shmem_create(struct drm_device *dev, size_t size, bool private) if (private) { drm_gem_private_object_init(dev, obj, size); - shmem->map_wc = false; /* dma-buf mappings use always writecombine */ + shmem->map_wc = false; /* dma-buf mappings are never write-combined */ } else { ret = drm_gem_object_init(dev, obj, size); }