| Message ID | 20240112234222.913138-2-anatoliy.klymenko@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fixing live video input in ZynqMP DPSUB | expand |
On 13/01/2024 01:42, Anatoliy Klymenko wrote: > Assign device of node to bridge prior registering it. This will > make said bridge discoverable by separate crtc driver. I think a few words on why this is needed (and why it wasn't needed before) would be nice. Other than that: Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Tomi > Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com> > --- > drivers/gpu/drm/xlnx/zynqmp_dp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c > index a0606fab0e22..d60b7431603f 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c > @@ -1721,6 +1721,7 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub) > bridge->ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID > | DRM_BRIDGE_OP_HPD; > bridge->type = DRM_MODE_CONNECTOR_DisplayPort; > + bridge->of_node = dp->dev->of_node; > dpsub->bridge = bridge; > > /*
On Wed, Jan 17, 2024 at 04:06:31PM +0200, Tomi Valkeinen wrote: > On 13/01/2024 01:42, Anatoliy Klymenko wrote: > > Assign device of node to bridge prior registering it. This will > > make said bridge discoverable by separate crtc driver. > > I think a few words on why this is needed (and why it wasn't needed > before) would be nice. > > Other than that: > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Agreed. With a better commit message, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com> > > --- > > drivers/gpu/drm/xlnx/zynqmp_dp.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c > > index a0606fab0e22..d60b7431603f 100644 > > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c > > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c > > @@ -1721,6 +1721,7 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub) > > bridge->ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID > > | DRM_BRIDGE_OP_HPD; > > bridge->type = DRM_MODE_CONNECTOR_DisplayPort; > > + bridge->of_node = dp->dev->of_node; > > dpsub->bridge = bridge; > > > > /*
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c index a0606fab0e22..d60b7431603f 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c @@ -1721,6 +1721,7 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub) bridge->ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_HPD; bridge->type = DRM_MODE_CONNECTOR_DisplayPort; + bridge->of_node = dp->dev->of_node; dpsub->bridge = bridge; /*
Assign device of node to bridge prior registering it. This will make said bridge discoverable by separate crtc driver. Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com> --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 1 + 1 file changed, 1 insertion(+)