| Message ID | 20240207161322.8073-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drivers/ps3: select VIDEO to provide cmdline functions | expand |
Am 07.02.24 um 17:13 schrieb Randy Dunlap: > When VIDEO is not set, there is a build error. Fix that by selecting > VIDEO for PS3_PS3AV. > > ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined! > > Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing") > Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter") > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Nicholas Piggin <npiggin@gmail.com> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu> > Cc: Aneesh Kumar K.V <aneesh.kumar@kernel.org> > Cc: Naveen N. Rao <naveen.n.rao@linux.ibm.com> > Cc: linuxppc-dev@lists.ozlabs.org > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Geoff Levand <geoff@infradead.org> > Acked-by: Geoff Levand <geoff@infradead.org> > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > v2: add Geoff's Ack; > add second Fixes: tag and more Cc:s (Thomas) > > arch/powerpc/platforms/ps3/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig > --- a/arch/powerpc/platforms/ps3/Kconfig > +++ b/arch/powerpc/platforms/ps3/Kconfig > @@ -67,6 +67,7 @@ config PS3_VUART > config PS3_PS3AV > depends on PPC_PS3 > tristate "PS3 AV settings driver" if PS3_ADVANCED > + select VIDEO > select PS3_VUART > default y > help
Thomas Zimmermann <tzimmermann@suse.de> writes: > Am 07.02.24 um 17:13 schrieb Randy Dunlap: >> When VIDEO is not set, there is a build error. Fix that by selecting >> VIDEO for PS3_PS3AV. >> >> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined! >> >> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing") >> Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter") >> Cc: Michael Ellerman <mpe@ellerman.id.au> >> Cc: Nicholas Piggin <npiggin@gmail.com> >> Cc: Christophe Leroy <christophe.leroy@csgroup.eu> >> Cc: Aneesh Kumar K.V <aneesh.kumar@kernel.org> >> Cc: Naveen N. Rao <naveen.n.rao@linux.ibm.com> >> Cc: linuxppc-dev@lists.ozlabs.org >> Cc: Thomas Zimmermann <tzimmermann@suse.de> >> Cc: Geoff Levand <geoff@infradead.org> >> Acked-by: Geoff Levand <geoff@infradead.org> >> Cc: linux-fbdev@vger.kernel.org >> Cc: dri-devel@lists.freedesktop.org >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Can you take it via whatever tree the CONFIG_VIDEO patch is in? Acked-by: Michael Ellerman <mpe@ellerman.id.au> cheers
Hi Am 09.02.24 um 06:15 schrieb Michael Ellerman: > Thomas Zimmermann <tzimmermann@suse.de> writes: >> Am 07.02.24 um 17:13 schrieb Randy Dunlap: >>> When VIDEO is not set, there is a build error. Fix that by selecting >>> VIDEO for PS3_PS3AV. >>> >>> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined! >>> >>> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing") >>> Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter") >>> Cc: Michael Ellerman <mpe@ellerman.id.au> >>> Cc: Nicholas Piggin <npiggin@gmail.com> >>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu> >>> Cc: Aneesh Kumar K.V <aneesh.kumar@kernel.org> >>> Cc: Naveen N. Rao <naveen.n.rao@linux.ibm.com> >>> Cc: linuxppc-dev@lists.ozlabs.org >>> Cc: Thomas Zimmermann <tzimmermann@suse.de> >>> Cc: Geoff Levand <geoff@infradead.org> >>> Acked-by: Geoff Levand <geoff@infradead.org> >>> Cc: linux-fbdev@vger.kernel.org >>> Cc: dri-devel@lists.freedesktop.org >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > Can you take it via whatever tree the CONFIG_VIDEO patch is in? The patch is now in drm-misc-next. Best regards Thomas > > Acked-by: Michael Ellerman <mpe@ellerman.id.au> > > cheers
diff -- a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig --- a/arch/powerpc/platforms/ps3/Kconfig +++ b/arch/powerpc/platforms/ps3/Kconfig @@ -67,6 +67,7 @@ config PS3_VUART config PS3_PS3AV depends on PPC_PS3 tristate "PS3 AV settings driver" if PS3_ADVANCED + select VIDEO select PS3_VUART default y help
When VIDEO is not set, there is a build error. Fix that by selecting VIDEO for PS3_PS3AV. ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined! Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing") Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter") Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Nicholas Piggin <npiggin@gmail.com> Cc: Christophe Leroy <christophe.leroy@csgroup.eu> Cc: Aneesh Kumar K.V <aneesh.kumar@kernel.org> Cc: Naveen N. Rao <naveen.n.rao@linux.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Geoff Levand <geoff@infradead.org> Acked-by: Geoff Levand <geoff@infradead.org> Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Randy Dunlap <rdunlap@infradead.org> --- v2: add Geoff's Ack; add second Fixes: tag and more Cc:s (Thomas) arch/powerpc/platforms/ps3/Kconfig | 1 + 1 file changed, 1 insertion(+)