From patchwork Mon Feb 26 21:20:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 13572894 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 803D9C48BF6 for ; Mon, 26 Feb 2024 21:21:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E961810E806; Mon, 26 Feb 2024 21:21:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="z/tTiTfH"; dkim-atps=neutral Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E7F010E806 for ; Mon, 26 Feb 2024 21:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1708982488; bh=w3le3Y2EYxbOx/Q57ccXOJbKsiJ/mZk+9wNEJ7K0FVs=; h=From:Date:Subject:To:Cc:From; b=z/tTiTfH7Oqezmj3gH/H/IANV/MOcJi/Yb8EIZz2oCKQ/V1zOYo25xeuSIJdRoQ/9 Ij1kPRdJlaSvE+MAHqcAWNuCcGyeyzR9UbWD1+mHsiYLIfB22ZimzTkgl25ezmRR4z 4TD6dj6tlyigSvvH0DvCuTMNhu8wb3NzAXcgg7ZCOP/h0GV/8SAy4mgLc3HbpJ9FxM z9T91Y6pf9tkV+garuHKcb9upsWSFizf7Yh8twiuEWmpZYRNNq1BmM97VHD8w5hexe fEcdke5uee2IKciDk6kWMTNgTYr77qRWlUY3c0R4r4cJhF+As/9Hc0bC/cIc2+BdIz XPV0d/b5rDTxQ== Received: from [192.168.1.151] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 53229378111A; Mon, 26 Feb 2024 21:21:25 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Mon, 26 Feb 2024 16:20:58 -0500 Subject: [PATCH] drm/bridge: anx7625: Don't log an error when DSI host can't be found MIME-Version: 1.0 Message-Id: <20240226-anx7625-defer-log-no-dsi-host-v1-1-242b1af31884@collabora.com> X-B4-Tracking: v=1; b=H4sIALkA3WUC/x3MwQqDMAwA0F+RnBfQ6NTtV2QHTVMNjHY0Mgriv 1s8vss7wCSpGLyrA5L81TSGguZRAW9zWAXVFQPV1NVEPc4hDz090YmXhN+4YojoTHGLtiO3/sW 88ELjAOX4JfGa73/6nOcFC4XP6G8AAAA= To: Robert Foss Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , AngeloGioacchino Del Regno , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 269332997a16 ("drm/bridge: anx7625: Return -EPROBE_DEFER if the dsi host was not found") Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- base-commit: 2ae0a045e6814c8c1d676d6153c605a65746aa29 change-id: 20240226-anx7625-defer-log-no-dsi-host-c3f9ccbcb287 Best regards, diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 29d91493b101..4ee5614a2623 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -2076,10 +2076,8 @@ static int anx7625_setup_dsi_device(struct anx7625_data *ctx) }; host = of_find_mipi_dsi_host_by_node(ctx->pdata.mipi_host_node); - if (!host) { - DRM_DEV_ERROR(dev, "fail to find dsi host.\n"); - return -EPROBE_DEFER; - } + if (!host) + return dev_err_probe(dev, -EPROBE_DEFER, "fail to find dsi host.\n"); dsi = devm_mipi_dsi_device_register_full(dev, host, &info); if (IS_ERR(dsi)) {