| Message ID | 20240228014435.7234-1-yaolu@kylinos.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions | expand |
Am 28.02.24 um 02:44 schrieb Lu Yao: > uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer. Yeah, but that is completely irrelevant here. We usually don't use the & for function pointers since that is unnecessary in C. Regards, Christian. > > Signed-off-by: Lu Yao <yaolu@kylinos.cn> > --- > drivers/gpu/drm/amd/amdgpu/si.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c > index a757526153e5..455d49f7bd9c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/si.c > +++ b/drivers/gpu/drm/amd/amdgpu/si.c > @@ -2032,8 +2032,8 @@ static int si_common_early_init(void *handle) > adev->pcie_wreg = &si_pcie_wreg; > adev->pciep_rreg = &si_pciep_rreg; > adev->pciep_wreg = &si_pciep_wreg; > - adev->uvd_ctx_rreg = si_uvd_ctx_rreg; > - adev->uvd_ctx_wreg = si_uvd_ctx_wreg; > + adev->uvd_ctx_rreg = &si_uvd_ctx_rreg; > + adev->uvd_ctx_wreg = &si_uvd_ctx_wreg; > adev->didt_rreg = NULL; > adev->didt_wreg = NULL; >
diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index a757526153e5..455d49f7bd9c 100644 --- a/drivers/gpu/drm/amd/amdgpu/si.c +++ b/drivers/gpu/drm/amd/amdgpu/si.c @@ -2032,8 +2032,8 @@ static int si_common_early_init(void *handle) adev->pcie_wreg = &si_pcie_wreg; adev->pciep_rreg = &si_pciep_rreg; adev->pciep_wreg = &si_pciep_wreg; - adev->uvd_ctx_rreg = si_uvd_ctx_rreg; - adev->uvd_ctx_wreg = si_uvd_ctx_wreg; + adev->uvd_ctx_rreg = &si_uvd_ctx_rreg; + adev->uvd_ctx_wreg = &si_uvd_ctx_wreg; adev->didt_rreg = NULL; adev->didt_wreg = NULL;
uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer. Signed-off-by: Lu Yao <yaolu@kylinos.cn> --- drivers/gpu/drm/amd/amdgpu/si.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)