| Message ID | 20240320131232.327196-1-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags | expand |
On 3/20/2024 6:12 AM, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > Similar to other variants, the LTK050H3148W wants to run in video mode > when displaying data. So far only the Synopsis DSI driver was using this > panel and it is always switching to video mode, independent of this flag > being set. > > Other DSI drivers might handle this differently, so add the flag. > > Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant") > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> Hi Heiko, Acked-by: Jessica Zhang <quic_jesszhan@quicinc.com> Thanks, Jessica Zhang > --- > drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > index 30919c872ac8..a50f5330a661 100644 > --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > @@ -326,7 +326,8 @@ static const struct drm_display_mode ltk050h3148w_mode = { > static const struct ltk050h3146w_desc ltk050h3148w_data = { > .mode = <k050h3148w_mode, > .init = ltk050h3148w_init_sequence, > - .mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE | MIPI_DSI_MODE_VIDEO_BURST, > + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > + MIPI_DSI_MODE_VIDEO_BURST, > }; > > static int ltk050h3146w_init_sequence(struct ltk050h3146w *ctx) > -- > 2.39.2 >
Hi Heiko, On 3/20/24 14:12, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > Similar to other variants, the LTK050H3148W wants to run in video mode > when displaying data. So far only the Synopsis DSI driver was using this > panel and it is always switching to video mode, independent of this flag > being set. > > Other DSI drivers might handle this differently, so add the flag. > > Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant") > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> Thanks! Quentin
On Wed, 20 Mar 2024 14:12:31 +0100, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > Similar to other variants, the LTK050H3148W wants to run in video mode > when displaying data. So far only the Synopsis DSI driver was using this > panel and it is always switching to video mode, independent of this flag > being set. > > [...] Applied, thanks! [1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags commit: 80cc8c0d09e6bab3bd016ddaccd0570cadbe1891 [2/2] drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W init commit: 55679cc22e60e8ec23b2340248389022798416cd Best regards,
diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c index 30919c872ac8..a50f5330a661 100644 --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c @@ -326,7 +326,8 @@ static const struct drm_display_mode ltk050h3148w_mode = { static const struct ltk050h3146w_desc ltk050h3148w_data = { .mode = <k050h3148w_mode, .init = ltk050h3148w_init_sequence, - .mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE | MIPI_DSI_MODE_VIDEO_BURST, + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | + MIPI_DSI_MODE_VIDEO_BURST, }; static int ltk050h3146w_init_sequence(struct ltk050h3146w *ctx)