| Message ID | 20240420-panel-sw43408-fix-v1-1-b282ff725242@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: two fixes for lg-sw43408 | expand |
On 20/04/2024 04:41, Dmitry Baryshkov wrote: > This panel driver uses DSC PPS functions and as such depends on the > DRM_DISPLAY_DP_HELPER. Add missing dependency > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202404200800.kYsRYyli-lkp@intel.com/ No Fixes ? > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/panel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index ab67789e59a2..5e6692207beb 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -340,6 +340,7 @@ config DRM_PANEL_LG_SW43408 > depends on OF > depends on DRM_MIPI_DSI > depends on BACKLIGHT_CLASS_DEVICE > + depends on DRM_DISPLAY_DP_HELPER > help > Say Y here if you want to enable support for LG sw43408 panel. > The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Wed, 24 Apr 2024 at 09:54, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > On 20/04/2024 04:41, Dmitry Baryshkov wrote: > > This panel driver uses DSC PPS functions and as such depends on the > > DRM_DISPLAY_DP_HELPER. Add missing dependency > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202404200800.kYsRYyli-lkp@intel.com/ > > No Fixes ? I'll add Fixes for v2. I'm waiting for the discussion on Kconfig to settle. > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > drivers/gpu/drm/panel/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > > index ab67789e59a2..5e6692207beb 100644 > > --- a/drivers/gpu/drm/panel/Kconfig > > +++ b/drivers/gpu/drm/panel/Kconfig > > @@ -340,6 +340,7 @@ config DRM_PANEL_LG_SW43408 > > depends on OF > > depends on DRM_MIPI_DSI > > depends on BACKLIGHT_CLASS_DEVICE > > + depends on DRM_DISPLAY_DP_HELPER > > help > > Say Y here if you want to enable support for LG sw43408 panel. > > The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per > > > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Hi, On Wed, Apr 24, 2024 at 10:43:32AM +0300, Dmitry Baryshkov wrote: > On Wed, 24 Apr 2024 at 09:54, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > > > On 20/04/2024 04:41, Dmitry Baryshkov wrote: > > > This panel driver uses DSC PPS functions and as such depends on the > > > DRM_DISPLAY_DP_HELPER. Add missing dependency > > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202404200800.kYsRYyli-lkp@intel.com/ > > > > No Fixes ? > > I'll add Fixes for v2. I'm waiting for the discussion on Kconfig to settle. > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > --- > > > drivers/gpu/drm/panel/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > > > index ab67789e59a2..5e6692207beb 100644 > > > --- a/drivers/gpu/drm/panel/Kconfig > > > +++ b/drivers/gpu/drm/panel/Kconfig > > > @@ -340,6 +340,7 @@ config DRM_PANEL_LG_SW43408 > > > depends on OF > > > depends on DRM_MIPI_DSI > > > depends on BACKLIGHT_CLASS_DEVICE > > > + depends on DRM_DISPLAY_DP_HELPER > > > help > > > Say Y here if you want to enable support for LG sw43408 panel. > > > The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per > > > > > > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> There's an ongoing discussion about reverting the whole Kconfig rework thing here and the dust hasn't settled yet: https://lore.kernel.org/r/cover.1713780345.git.geert+renesas@glider.be I don't think there's anything you need to do now, but it's probably good to keep it in mind. Maxime
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index ab67789e59a2..5e6692207beb 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -340,6 +340,7 @@ config DRM_PANEL_LG_SW43408 depends on OF depends on DRM_MIPI_DSI depends on BACKLIGHT_CLASS_DEVICE + depends on DRM_DISPLAY_DP_HELPER help Say Y here if you want to enable support for LG sw43408 panel. The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per
This panel driver uses DSC PPS functions and as such depends on the DRM_DISPLAY_DP_HELPER. Add missing dependency Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202404200800.kYsRYyli-lkp@intel.com/ Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/panel/Kconfig | 1 + 1 file changed, 1 insertion(+)