From patchwork Thu Apr 25 12:42:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13643282 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10A80C4345F for ; Thu, 25 Apr 2024 12:42:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D7CA10FFE9; Thu, 25 Apr 2024 12:42:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ij7oVQmi"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9050C10FFE9 for ; Thu, 25 Apr 2024 12:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714048936; x=1745584936; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Xd08opKedHrtsU4GnsZbUiXElSa9U0/jkuoALRq3DZw=; b=ij7oVQmixMX5go7zjoiieegSJIiC9FpzV+dECme6hc/Ce/p9yr+KwEwg aeviq23W+pogOotFYTfhpv+RkmSHC2LtRqWhviRUGIHgVOdp+9HJ/g8en 7qYtVCkZwG8tzcM7Ub8jPQfiNnX2IlhCK2aR5FY02JWkRNngrw6aXWZHT eUPO/HwLdKBpY1aXrrEDyv+Q1T/3imhWDwrYkRZ51YvgtVncDpxCXAfQ+ Dw8StnNd6mBdM+Vp6a953CbmL+kviKXosoWKOKHlrkMJzeVVlmYMo1uDx df55aTp/Rb0Y0iZNBG3aaTJTMRoMm6H7rpRw5fl5aFFeI4/0FReXTe9Ql w==; X-CSE-ConnectionGUID: ifRlMEAASla5lCGIVn52bw== X-CSE-MsgGUID: IYeYNTG+QlKeJAMAcf5TSQ== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="9555808" X-IronPort-AV: E=Sophos;i="6.07,229,1708416000"; d="scan'208";a="9555808" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 05:42:15 -0700 X-CSE-ConnectionGUID: feb0LlWDTY6pGqiTfw9FeA== X-CSE-MsgGUID: i5mRVIGfShCstltnol8NSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,229,1708416000"; d="scan'208";a="62539171" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa001.jf.intel.com with ESMTP; 25 Apr 2024 05:42:12 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id EA79253E; Thu, 25 Apr 2024 15:42:10 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , =?utf-8?q?Noralf_Tr=C3=B8nnes?= , David Lechner , Helge Deller , linux-fbdev@vger.kernel.org Subject: [PATCH v1 1/1] drm/ili9341: Remove the duplicative driver Date: Thu, 25 Apr 2024 15:42:07 +0300 Message-ID: <20240425124208.2255265-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" First of all, the driver was introduced when it was already two drivers available for Ilitek 9341 panels. Second, the most recent (fourth!) driver has incorporated this one and hence, when enabled, it covers the provided functionality. Taking into account the above, remove duplicative driver and make maintenance and support eaiser for everybody. Also see discussion [1] for details about Ilitek 9341 duplication code. Link: https://lore.kernel.org/r/ZXM9pG-53V4S8E2H@smile.fi.intel.com [1] Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/Kconfig | 13 -- drivers/gpu/drm/tiny/Makefile | 1 - drivers/gpu/drm/tiny/ili9341.c | 253 --------------------------------- 3 files changed, 267 deletions(-) delete mode 100644 drivers/gpu/drm/tiny/ili9341.c diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig index f6889f649bc1..2ab07bd0bb44 100644 --- a/drivers/gpu/drm/tiny/Kconfig +++ b/drivers/gpu/drm/tiny/Kconfig @@ -134,19 +134,6 @@ config TINYDRM_ILI9225 If M is selected the module will be called ili9225. -config TINYDRM_ILI9341 - tristate "DRM support for ILI9341 display panels" - depends on DRM && SPI - select DRM_KMS_HELPER - select DRM_GEM_DMA_HELPER - select DRM_MIPI_DBI - select BACKLIGHT_CLASS_DEVICE - help - DRM driver for the following Ilitek ILI9341 panels: - * YX240QV29-T 2.4" 240x320 TFT (Adafruit 2.4") - - If M is selected the module will be called ili9341. - config TINYDRM_ILI9486 tristate "DRM support for ILI9486 display panels" depends on DRM && SPI diff --git a/drivers/gpu/drm/tiny/Makefile b/drivers/gpu/drm/tiny/Makefile index 76dde89a044b..37cc9b27e79d 100644 --- a/drivers/gpu/drm/tiny/Makefile +++ b/drivers/gpu/drm/tiny/Makefile @@ -10,7 +10,6 @@ obj-$(CONFIG_DRM_SIMPLEDRM) += simpledrm.o obj-$(CONFIG_TINYDRM_HX8357D) += hx8357d.o obj-$(CONFIG_TINYDRM_ILI9163) += ili9163.o obj-$(CONFIG_TINYDRM_ILI9225) += ili9225.o -obj-$(CONFIG_TINYDRM_ILI9341) += ili9341.o obj-$(CONFIG_TINYDRM_ILI9486) += ili9486.o obj-$(CONFIG_TINYDRM_MI0283QT) += mi0283qt.o obj-$(CONFIG_TINYDRM_REPAPER) += repaper.o diff --git a/drivers/gpu/drm/tiny/ili9341.c b/drivers/gpu/drm/tiny/ili9341.c deleted file mode 100644 index 47b61c3bf145..000000000000 --- a/drivers/gpu/drm/tiny/ili9341.c +++ /dev/null @@ -1,253 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ -/* - * DRM driver for Ilitek ILI9341 panels - * - * Copyright 2018 David Lechner - * - * Based on mi0283qt.c: - * Copyright 2016 Noralf Trønnes - */ - -#include -#include -#include -#include -#include -#include - -#include -#include -#include -#include -#include -#include -#include -#include -#include