| Message ID | 20240425142706.2440113-4-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: ili9341: Obvious fixes | expand |
On 25/04/2024 16:26, Andy Shevchenko wrote: > In one case the -1 is returned which is quite confusing code for > the wrong device ID, in another the ret is returning instead of > plain 0 that also confusing as readed may ask the possible meaning > of positive codes, which are never the case there. Convert both > to use explicit predefined error codes to make it clear what's going > on there. > > Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > index 24c74c56e564..b933380b7eb7 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > @@ -422,7 +422,7 @@ static int ili9341_dpi_prepare(struct drm_panel *panel) > > ili9341_dpi_init(ili); > > - return ret; > + return 0; > } > > static int ili9341_dpi_enable(struct drm_panel *panel) > @@ -726,7 +726,7 @@ static int ili9341_probe(struct spi_device *spi) > else if (!strcmp(id->name, "yx240qv29")) > return ili9341_dbi_probe(spi, dc, reset); > > - return -1; > + return -ENODEV; > } > > static void ili9341_remove(struct spi_device *spi) Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 2024/4/25 22:26, Andy Shevchenko wrote: > In one case the -1 is returned which is quite confusing code for > the wrong device ID, in another the ret is returning instead of > plain 0 that also confusing as readed may ask the possible meaning > of positive codes, which are never the case there. Convert both > to use explicit predefined error codes to make it clear what's going > on there. > > Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Sui Jingfeng <sui.jingfeng@linux.dev>
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c index 24c74c56e564..b933380b7eb7 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c @@ -422,7 +422,7 @@ static int ili9341_dpi_prepare(struct drm_panel *panel) ili9341_dpi_init(ili); - return ret; + return 0; } static int ili9341_dpi_enable(struct drm_panel *panel) @@ -726,7 +726,7 @@ static int ili9341_probe(struct spi_device *spi) else if (!strcmp(id->name, "yx240qv29")) return ili9341_dbi_probe(spi, dc, reset); - return -1; + return -ENODEV; } static void ili9341_remove(struct spi_device *spi)
In one case the -1 is returned which is quite confusing code for the wrong device ID, in another the ret is returning instead of plain 0 that also confusing as readed may ask the possible meaning of positive codes, which are never the case there. Convert both to use explicit predefined error codes to make it clear what's going on there. Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)