diff mbox series

[v2,5/8] drm/mipi-dsi: mipi_dsi_*_write functions don't need to ratelimit prints

Message ID 20240426165839.v2.5.I9982cd5d8014de7a4513f5619f66f88da49ce4ec@changeid (mailing list archive)
State New, archived
Headers show
Series drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs | expand

Commit Message

Doug Anderson April 26, 2024, 11:58 p.m. UTC 
We really don't expect these errors to be printed over and over
again. When a driver hits the error it should bail out. Just use a
normal error print.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

Changes in v2:
- New

 drivers/gpu/drm/drm_mipi_dsi.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index b7c75a4396e6..8bc2db971e93 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -770,7 +770,7 @@  EXPORT_SYMBOL(mipi_dsi_generic_write);
  * @payload: buffer containing the payload
  * @size: size of payload buffer
  *
- * Like mipi_dsi_generic_write() but includes a dev_err_ratelimited()
+ * Like mipi_dsi_generic_write() but includes a dev_err()
  * call for you and returns 0 upon success, not the number of bytes sent.
  *
  * Return: 0 on success or a negative error code on failure.
@@ -783,8 +783,8 @@  int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi,
 
 	ret = mipi_dsi_generic_write(dsi, payload, size);
 	if (ret < 0) {
-		dev_err_ratelimited(dev, "sending generic data %*ph failed: %d\n",
-				    (int)size, payload, (int)ret);
+		dev_err(dev, "sending generic data %*ph failed: %d\n",
+			(int)size, payload, (int)ret);
 		return ret;
 	}
 
@@ -814,8 +814,8 @@  void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx,
 	ret = mipi_dsi_generic_write(dsi, payload, size);
 	if (ret < 0) {
 		ctx->accum_err = ret;
-		dev_err_ratelimited(dev, "sending generic data %*ph failed: %d\n",
-				    (int)size, payload, ctx->accum_err);
+		dev_err(dev, "sending generic data %*ph failed: %d\n",
+			(int)size, payload, ctx->accum_err);
 	}
 }
 EXPORT_SYMBOL(mipi_dsi_generic_write_multi);
@@ -914,7 +914,7 @@  EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer);
  * @data: buffer containing data to be transmitted
  * @len: size of transmission buffer
  *
- * Like mipi_dsi_dcs_write_buffer() but includes a dev_err_ratelimited()
+ * Like mipi_dsi_dcs_write_buffer() but includes a dev_err()
  * call for you and returns 0 upon success, not the number of bytes sent.
  *
  * Return: 0 on success or a negative error code on failure.
@@ -927,8 +927,8 @@  int mipi_dsi_dcs_write_buffer_chatty(struct mipi_dsi_device *dsi,
 
 	ret = mipi_dsi_dcs_write_buffer(dsi, data, len);
 	if (ret < 0) {
-		dev_err_ratelimited(dev, "sending dcs data %*ph failed: %d\n",
-				    (int)len, data, (int)ret);
+		dev_err(dev, "sending dcs data %*ph failed: %d\n",
+			(int)len, data, (int)ret);
 		return ret;
 	}
 
@@ -958,8 +958,8 @@  void mipi_dsi_dcs_write_buffer_multi(struct mipi_dsi_multi_context *ctx,
 	ret = mipi_dsi_dcs_write_buffer(dsi, data, len);
 	if (ret < 0) {
 		ctx->accum_err = ret;
-		dev_err_ratelimited(dev, "sending dcs data %*ph failed: %d\n",
-				    (int)len, data, ctx->accum_err);
+		dev_err(dev, "sending dcs data %*ph failed: %d\n",
+			(int)len, data, ctx->accum_err);
 	}
 }
 EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer_multi);