diff mbox series

agp: add missing MODULE_DESCRIPTION() macros

Message ID 20240603-md-agp-v1-1-9a1582114ced@quicinc.com (mailing list archive)
State New, archived
Headers show
Series agp: add missing MODULE_DESCRIPTION() macros | expand

Commit Message

Jeff Johnson June 3, 2024, 4:55 p.m. UTC 
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/amd64-agp.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/intel-agp.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/intel-gtt.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/sis-agp.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/via-agp.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/char/agp/amd64-agp.c | 1 +
 drivers/char/agp/intel-agp.c | 1 +
 drivers/char/agp/intel-gtt.c | 1 +
 drivers/char/agp/sis-agp.c   | 1 +
 drivers/char/agp/via-agp.c   | 1 +
 5 files changed, 5 insertions(+)


---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240603-md-agp-68a9e38017af

Comments

Jeff Johnson June 23, 2024, 5:37 p.m. UTC | #1 
On 6/3/2024 9:55 AM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/amd64-agp.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/intel-agp.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/intel-gtt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/sis-agp.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/via-agp.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/char/agp/amd64-agp.c | 1 +
>  drivers/char/agp/intel-agp.c | 1 +
>  drivers/char/agp/intel-gtt.c | 1 +
>  drivers/char/agp/sis-agp.c   | 1 +
>  drivers/char/agp/via-agp.c   | 1 +
>  5 files changed, 5 insertions(+)
> 
> diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
> index ce8651436609..8e41731d3642 100644
> --- a/drivers/char/agp/amd64-agp.c
> +++ b/drivers/char/agp/amd64-agp.c
> @@ -802,4 +802,5 @@ module_exit(agp_amd64_cleanup);
>  
>  MODULE_AUTHOR("Dave Jones, Andi Kleen");
>  module_param(agp_try_unsupported, bool, 0);
> +MODULE_DESCRIPTION("GART driver for the AMD Opteron/Athlon64 on-CPU northbridge");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
> index c518b3a9db04..2c55264a031e 100644
> --- a/drivers/char/agp/intel-agp.c
> +++ b/drivers/char/agp/intel-agp.c
> @@ -920,4 +920,5 @@ module_init(agp_intel_init);
>  module_exit(agp_intel_cleanup);
>  
>  MODULE_AUTHOR("Dave Jones, Various @Intel");
> +MODULE_DESCRIPTION("Intel AGPGART routines");
>  MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
> index bf6716ff863b..e54649027407 100644
> --- a/drivers/char/agp/intel-gtt.c
> +++ b/drivers/char/agp/intel-gtt.c
> @@ -1461,4 +1461,5 @@ void intel_gmch_remove(void)
>  EXPORT_SYMBOL(intel_gmch_remove);
>  
>  MODULE_AUTHOR("Dave Jones, Various @Intel");
> +MODULE_DESCRIPTION("Intel GTT (Graphics Translation Table) routines");
>  MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/char/agp/sis-agp.c b/drivers/char/agp/sis-agp.c
> index 484bb101c53b..a0deb97cedb0 100644
> --- a/drivers/char/agp/sis-agp.c
> +++ b/drivers/char/agp/sis-agp.c
> @@ -433,4 +433,5 @@ module_param(agp_sis_force_delay, bool, 0);
>  MODULE_PARM_DESC(agp_sis_force_delay,"forces sis delay hack");
>  module_param(agp_sis_agp_spec, int, 0);
>  MODULE_PARM_DESC(agp_sis_agp_spec,"0=force sis init, 1=force generic agp3 init, default: autodetect");
> +MODULE_DESCRIPTION("SiS AGPGART routines");
>  MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/char/agp/via-agp.c b/drivers/char/agp/via-agp.c
> index bc5140af2dcb..8b19a5d1a09b 100644
> --- a/drivers/char/agp/via-agp.c
> +++ b/drivers/char/agp/via-agp.c
> @@ -575,5 +575,6 @@ static void __exit agp_via_cleanup(void)
>  module_init(agp_via_init);
>  module_exit(agp_via_cleanup);
>  
> +MODULE_DESCRIPTION("VIA AGPGART routines");
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Dave Jones");
> 
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240603-md-agp-68a9e38017af
> 

Following up to see if anything else is needed from me.
Hoping to see this in linux-next :)

/jeff
Dave Airlie June 24, 2024, 6:21 a.m. UTC | #2 
>
> Following up to see if anything else is needed from me.
> Hoping to see this in linux-next :)

I just pushed this into drm-next.

Thanks,
Dave.
diff mbox series

Patch

diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index ce8651436609..8e41731d3642 100644
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -802,4 +802,5 @@  module_exit(agp_amd64_cleanup);
 
 MODULE_AUTHOR("Dave Jones, Andi Kleen");
 module_param(agp_try_unsupported, bool, 0);
+MODULE_DESCRIPTION("GART driver for the AMD Opteron/Athlon64 on-CPU northbridge");
 MODULE_LICENSE("GPL");
diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index c518b3a9db04..2c55264a031e 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -920,4 +920,5 @@  module_init(agp_intel_init);
 module_exit(agp_intel_cleanup);
 
 MODULE_AUTHOR("Dave Jones, Various @Intel");
+MODULE_DESCRIPTION("Intel AGPGART routines");
 MODULE_LICENSE("GPL and additional rights");
diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
index bf6716ff863b..e54649027407 100644
--- a/drivers/char/agp/intel-gtt.c
+++ b/drivers/char/agp/intel-gtt.c
@@ -1461,4 +1461,5 @@  void intel_gmch_remove(void)
 EXPORT_SYMBOL(intel_gmch_remove);
 
 MODULE_AUTHOR("Dave Jones, Various @Intel");
+MODULE_DESCRIPTION("Intel GTT (Graphics Translation Table) routines");
 MODULE_LICENSE("GPL and additional rights");
diff --git a/drivers/char/agp/sis-agp.c b/drivers/char/agp/sis-agp.c
index 484bb101c53b..a0deb97cedb0 100644
--- a/drivers/char/agp/sis-agp.c
+++ b/drivers/char/agp/sis-agp.c
@@ -433,4 +433,5 @@  module_param(agp_sis_force_delay, bool, 0);
 MODULE_PARM_DESC(agp_sis_force_delay,"forces sis delay hack");
 module_param(agp_sis_agp_spec, int, 0);
 MODULE_PARM_DESC(agp_sis_agp_spec,"0=force sis init, 1=force generic agp3 init, default: autodetect");
+MODULE_DESCRIPTION("SiS AGPGART routines");
 MODULE_LICENSE("GPL and additional rights");
diff --git a/drivers/char/agp/via-agp.c b/drivers/char/agp/via-agp.c
index bc5140af2dcb..8b19a5d1a09b 100644
--- a/drivers/char/agp/via-agp.c
+++ b/drivers/char/agp/via-agp.c
@@ -575,5 +575,6 @@  static void __exit agp_via_cleanup(void)
 module_init(agp_via_init);
 module_exit(agp_via_cleanup);
 
+MODULE_DESCRIPTION("VIA AGPGART routines");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Dave Jones");