| Message ID | 20240716121112.14435-2-lvzhaoxiong@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Modify the method of obtaining porch parameters | expand |
Hi, On Tue, Jul 16, 2024 at 5:11 AM Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > The current driver can only obtain the porch parameters > of boe-th101mb31ig002. Modify it to obtain the porch > parameters of the panel currently being used. > > Fixes: 24179ff9a2e4524 ("drm/panel: boe-th101mb31ig002 : Make it compatible with other panel.") > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > --- > Changes between V2 and V1: > - 1. No changes, Modify the commit information format. > v1: https://lore.kernel.org/all/20240715031845.6687-2-lvzhaoxiong@huaqin.corp-partner.google.com/ > --- > drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org> I assume we'd want to see a re-post of this series with patch #2 comments addressed before landing? What do others think?
diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c index b55cf80c5522..d4e4abd103bb 100644 --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c @@ -312,15 +312,14 @@ static int boe_th101mb31ig002_get_modes(struct drm_panel *panel, struct boe_th101mb31ig002 *ctx = container_of(panel, struct boe_th101mb31ig002, panel); + const struct drm_display_mode *desc_mode = ctx->desc->modes; struct drm_display_mode *mode; - mode = drm_mode_duplicate(connector->dev, - &boe_th101mb31ig002_default_mode); + mode = drm_mode_duplicate(connector->dev, desc_mode); if (!mode) { dev_err(panel->dev, "Failed to add mode %ux%u@%u\n", - boe_th101mb31ig002_default_mode.hdisplay, - boe_th101mb31ig002_default_mode.vdisplay, - drm_mode_vrefresh(&boe_th101mb31ig002_default_mode)); + desc_mode->hdisplay, desc_mode->vdisplay, + drm_mode_vrefresh(desc_mode)); return -ENOMEM; }
The current driver can only obtain the porch parameters of boe-th101mb31ig002. Modify it to obtain the porch parameters of the panel currently being used. Fixes: 24179ff9a2e4524 ("drm/panel: boe-th101mb31ig002 : Make it compatible with other panel.") Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> --- Changes between V2 and V1: - 1. No changes, Modify the commit information format. v1: https://lore.kernel.org/all/20240715031845.6687-2-lvzhaoxiong@huaqin.corp-partner.google.com/ --- drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)