diff mbox series

drm/msm: Remove unused declaraions

Message ID 20240815111936.78601-1-zhangzekun11@huawei.com (mailing list archive)
State New, archived
Headers show
Series drm/msm: Remove unused declaraions | expand

Commit Message

zhangzekun (A) Aug. 15, 2024, 11:19 a.m. UTC
The definition of msm_atomic_state_clear() and msm_atomic_state_free()
has been removed since commit c21c731d93e8 ("drm/msm: Don't subclass
drm_atomic_state anymore").

Also, the definition of msm_dsi_host_set_src_pll() has been removed
since commit 9b077c1581cf ("drm/msm/dsi: stop setting clock parents
manually"). So, let's remove this unused declarations.

Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
---
 drivers/gpu/drm/msm/dsi/dsi.h | 2 --
 drivers/gpu/drm/msm/msm_drv.h | 2 --
 2 files changed, 4 deletions(-)

Comments

Abhinav Kumar Aug. 16, 2024, 5:41 p.m. UTC | #1
On 8/15/2024 4:19 AM, Zhang Zekun wrote:
> The definition of msm_atomic_state_clear() and msm_atomic_state_free()
> has been removed since commit c21c731d93e8 ("drm/msm: Don't subclass
> drm_atomic_state anymore").
> 
> Also, the definition of msm_dsi_host_set_src_pll() has been removed
> since commit 9b077c1581cf ("drm/msm/dsi: stop setting clock parents
> manually"). So, let's remove this unused declarations.
> 
> Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
> ---
>   drivers/gpu/drm/msm/dsi/dsi.h | 2 --
>   drivers/gpu/drm/msm/msm_drv.h | 2 --
>   2 files changed, 4 deletions(-)
> 

It looks like you did not run get_maintainers.pl because freedreno list 
is not CCed on this. For future reference, please do to get our attention.

The change itself is fine, hence

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h
index 87496db203d6..6ffc8a3b6c72 100644
--- a/drivers/gpu/drm/msm/dsi/dsi.h
+++ b/drivers/gpu/drm/msm/dsi/dsi.h
@@ -85,8 +85,6 @@  int msm_dsi_host_register(struct mipi_dsi_host *host);
 void msm_dsi_host_unregister(struct mipi_dsi_host *host);
 void msm_dsi_host_set_phy_mode(struct mipi_dsi_host *host,
 			struct msm_dsi_phy *src_phy);
-int msm_dsi_host_set_src_pll(struct mipi_dsi_host *host,
-			struct msm_dsi_phy *src_phy);
 void msm_dsi_host_reset_phy(struct mipi_dsi_host *host);
 void msm_dsi_host_get_phy_clk_req(struct mipi_dsi_host *host,
 	struct msm_dsi_phy_clk_request *clk_req,
diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
index be016d7b4ef1..48799c678a6b 100644
--- a/drivers/gpu/drm/msm/msm_drv.h
+++ b/drivers/gpu/drm/msm/msm_drv.h
@@ -254,8 +254,6 @@  void msm_atomic_destroy_pending_timer(struct msm_pending_timer *timer);
 void msm_atomic_commit_tail(struct drm_atomic_state *state);
 int msm_atomic_check(struct drm_device *dev, struct drm_atomic_state *state);
 struct drm_atomic_state *msm_atomic_state_alloc(struct drm_device *dev);
-void msm_atomic_state_clear(struct drm_atomic_state *state);
-void msm_atomic_state_free(struct drm_atomic_state *state);
 
 int msm_crtc_enable_vblank(struct drm_crtc *crtc);
 void msm_crtc_disable_vblank(struct drm_crtc *crtc);