| Message ID | 20240904012456.35429-2-ryan@testtoast.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Correct WL-355608-A8 panel compatible | expand |
On Wed, 04 Sep 2024 13:23:21 +1200, Ryan Walklin wrote: > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown > OEM used in a number of handheld gaming devices made by Anbernic. > Previously committed using the OEM serial without a vendor prefix, > however following subsequent discussion the preference is to use the > integrating device vendor and name where the OEM is unknown. > > There are 4 RG35XX series devices from Anbernic based on an Allwinner > H700 SoC using this panel, with the -Plus variant introduced first. > Therefore the -Plus is used as the fallback for the subsequent -H, > -2024, and -SP devices. > > Alter the filename and compatible string to reflect the convention. > > Fixes: f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel") > Signed-off-by: Ryan Walklin <ryan@testtoast.com> > > -- > Changelog v1..v2: > - Use known panel serial for compatible name rather than referencing > integrating devices as per feedback [1] from DT maintainers. > > Changelog v2..v3: > - Use integrating device names rather than panel serial number for > compatible string as per further maintainer feedback [2]. > > [1] https://lore.kernel.org/linux-devicetree/8b4519fc-0fba-48fe-bfb4-318818b47a65@app.fastmail.com/#t > > [2] https://lore.kernel.org/dri-devel/6ab54fb5-8723-457d-b5e6-483f82faf30e@app.fastmail.com/ > --- > ...08-a8.yaml => anbernic,rg35xx-plus-panel.yaml} | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-plus-panel.yaml} (67%) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
On Wed, 04 Sep 2024 13:23:21 +1200, Ryan Walklin wrote: > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown > OEM used in a number of handheld gaming devices made by Anbernic. > Previously committed using the OEM serial without a vendor prefix, > however following subsequent discussion the preference is to use the > integrating device vendor and name where the OEM is unknown. > > There are 4 RG35XX series devices from Anbernic based on an Allwinner > H700 SoC using this panel, with the -Plus variant introduced first. > Therefore the -Plus is used as the fallback for the subsequent -H, > -2024, and -SP devices. > > [...] Applied to misc/kernel.git (drm-misc-fixes). Thanks! Maxime
diff --git a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-plus-panel.yaml similarity index 67% rename from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml rename to Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-plus-panel.yaml index e552d01b52b97..1d67492ebd3b4 100644 --- a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +++ b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-plus-panel.yaml @@ -1,10 +1,10 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml# +$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-plus-panel.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel +title: Anbernic RG35XX series (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel maintainers: - Ryan Walklin <ryan@testtoast.com> @@ -15,7 +15,14 @@ allOf: properties: compatible: - const: wl-355608-a8 + oneOf: + - const: anbernic,rg35xx-plus-panel + - items: + - enum: + - anbernic,rg35xx-2024-panel + - anbernic,rg35xx-h-panel + - anbernic,rg35xx-sp-panel + - const: anbernic,rg35xx-plus-panel reg: maxItems: 1 @@ -40,7 +47,7 @@ examples: #size-cells = <0>; panel@0 { - compatible = "wl-355608-a8"; + compatible = "anbernic,rg35xx-plus-panel"; reg = <0>; spi-3wire;
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however following subsequent discussion the preference is to use the integrating device vendor and name where the OEM is unknown. There are 4 RG35XX series devices from Anbernic based on an Allwinner H700 SoC using this panel, with the -Plus variant introduced first. Therefore the -Plus is used as the fallback for the subsequent -H, -2024, and -SP devices. Alter the filename and compatible string to reflect the convention. Fixes: f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel") Signed-off-by: Ryan Walklin <ryan@testtoast.com> -- Changelog v1..v2: - Use known panel serial for compatible name rather than referencing integrating devices as per feedback [1] from DT maintainers. Changelog v2..v3: - Use integrating device names rather than panel serial number for compatible string as per further maintainer feedback [2]. [1] https://lore.kernel.org/linux-devicetree/8b4519fc-0fba-48fe-bfb4-318818b47a65@app.fastmail.com/#t [2] https://lore.kernel.org/dri-devel/6ab54fb5-8723-457d-b5e6-483f82faf30e@app.fastmail.com/ --- ...08-a8.yaml => anbernic,rg35xx-plus-panel.yaml} | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-plus-panel.yaml} (67%)