[RFC,2/2] drm/sched: Remove drm_sched_entity_set_priority

Commit Message

Tvrtko Ursulin Sept. 6, 2024, 6:06 p.m. UTC

From: Tvrtko Ursulin <[e-mail]>

Now that no callers exist, lets remove the whole misleading helper.

Misleading because runtime changes do not reliably work due
drm_sched_entity_select_rq() only acting on idle entities.

Signed-off-by: Tvrtko Ursulin <[e-mail]>
Cc: Christian König <[e-mail]>
Cc: Alex Deucher <[e-mail]>
Cc: Luben Tuikov <[e-mail]>
Cc: Matthew Brost <[e-mail]>
---
 drivers/gpu/drm/scheduler/sched_entity.c | 22 ++--------------------
 include/drm/gpu_scheduler.h              |  2 --
 2 files changed, 2 insertions(+), 22 deletions(-)

Patch

diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
index 8f40701bd801..8002755661ac 100644
--- a/drivers/gpu/drm/scheduler/sched_entity.c
+++ b/drivers/gpu/drm/scheduler/sched_entity.c
@@ -47,9 +47,8 @@ 
  *
  * Note that the &sched_list must have at least one element to schedule the entity.
  *
- * For changing @priority later on at runtime see
- * drm_sched_entity_set_priority(). For changing the set of schedulers
- * @sched_list at runtime see drm_sched_entity_modify_sched().
+ * For changing the set of schedulers @sched_list at runtime see
+ * drm_sched_entity_modify_sched().
  *
  * An entity is cleaned up by callind drm_sched_entity_fini(). See also
  * drm_sched_entity_destroy().
@@ -385,23 +384,6 @@  static void drm_sched_entity_wakeup(struct dma_fence *f,
 	drm_sched_wakeup(entity->rq->sched, entity);
 }
 
-/**
- * drm_sched_entity_set_priority - Sets priority of the entity
- *
- * @entity: scheduler entity
- * @priority: scheduler priority
- *
- * Update the priority of runqueus used for the entity.
- */
-void drm_sched_entity_set_priority(struct drm_sched_entity *entity,
-				   enum drm_sched_priority priority)
-{
-	spin_lock(&entity->rq_lock);
-	entity->priority = priority;
-	spin_unlock(&entity->rq_lock);
-}
-EXPORT_SYMBOL(drm_sched_entity_set_priority);
-
 /*
  * Add a callback to the current dependency of the entity to wake up the
  * scheduler when the entity becomes available.
diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
index a06753987d93..f078842423f4 100644
--- a/include/drm/gpu_scheduler.h
+++ b/include/drm/gpu_scheduler.h
@@ -607,8 +607,6 @@  void drm_sched_entity_destroy(struct drm_sched_entity *entity);
 void drm_sched_entity_select_rq(struct drm_sched_entity *entity);
 struct drm_sched_job *drm_sched_entity_pop_job(struct drm_sched_entity *entity);
 void drm_sched_entity_push_job(struct drm_sched_job *sched_job);
-void drm_sched_entity_set_priority(struct drm_sched_entity *entity,
-				   enum drm_sched_priority priority);
 bool drm_sched_entity_is_ready(struct drm_sched_entity *entity);
 int drm_sched_entity_error(struct drm_sched_entity *entity);