[WIP,RFC,v2,26/35] WIP: rust: drm/kms: Add RawPlaneState::atomic_helper_check()

Commit Message

Lyude Paul Sept. 30, 2024, 11:10 p.m. UTC

Add a binding for drm_atomic_helper_check_plane_state(). Since we want to
make sure that the user is passing in the new state for a Crtc instead of
an old state, we explicitly ask for a reference to a BorrowedCrtcState.

Signed-off-by: Lyude Paul <[e-mail]>

---

TODO:
* Add support for scaling options

Signed-off-by: Lyude Paul <[e-mail]>
---
 rust/kernel/drm/kms/plane.rs | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Patch

diff --git a/rust/kernel/drm/kms/plane.rs b/rust/kernel/drm/kms/plane.rs
index 4d16d53179fca..cd5167e6441f1 100644
--- a/rust/kernel/drm/kms/plane.rs
+++ b/rust/kernel/drm/kms/plane.rs
@@ -496,6 +496,31 @@  fn crtc<'a, 'b: 'a>(&'a self) -> Option<&'b OpaqueCrtc<<Self::Plane as ModeObjec
         // SAFETY: This cast is guaranteed safe by `OpaqueCrtc`s invariants.
         NonNull::new(self.as_raw().crtc).map(|c| unsafe { OpaqueCrtc::from_raw(c.as_ptr()) })
     }
+
+    /// Run the atomic check helper for this plane and the given CRTC state
+    fn atomic_helper_check<S>(
+        &mut self,
+        crtc_state: &BorrowedCrtcState<'_, S>,
+        can_position: bool,
+        can_update_disabled: bool
+    ) -> Result
+    where
+        S: FromRawCrtcState,
+        S::Crtc: AsRawCrtc<Driver = <Self::Plane as ModeObject>::Driver>
+    {
+        // SAFETY: We're passing the mutable reference from `self.as_raw_mut()` directly to DRM,
+        // which is safe.
+        to_result(unsafe {
+            bindings::drm_atomic_helper_check_plane_state(
+                self.as_raw_mut(),
+                crtc_state.as_raw(),
+                bindings::DRM_PLANE_NO_SCALING as _, // TODO: add parameters for scaling
+                bindings::DRM_PLANE_NO_SCALING as _,
+                can_position,
+                can_update_disabled
+            )
+        })
+    }
 }
 impl<T: AsRawPlaneState + ?Sized> RawPlaneState for T {}