| Message ID | 20241002-vc4_fbdev_fix-v1-1-8737bd11b147@raspberrypi.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Fix up and error handling after fbdev changes | expand |
Hi Dave, On 10/2/24 12:06, Dave Stevenson wrote: > Commit 45903624e9fc ("drm/vc4: Run DRM default client setup") > only added DRM_FBDEV_DMA_DRIVER_OPS for the vc4 (Pi0-3) driver > definition, which caused an issue on vc5 (Pi4) as there was no > fbdev_probe function defined. > > Fixes: 45903624e9fc ("drm/vc4: Run DRM default client setup") > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Reviewed-by: Maíra Canal <mcanal@igalia.com> Best Regards, - Maíra > --- > drivers/gpu/drm/vc4/vc4_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c > index 13a1ecddbca3..a238f76a6073 100644 > --- a/drivers/gpu/drm/vc4/vc4_drv.c > +++ b/drivers/gpu/drm/vc4/vc4_drv.c > @@ -238,6 +238,7 @@ const struct drm_driver vc5_drm_driver = { > #endif > > DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(vc5_dumb_create), > + DRM_FBDEV_DMA_DRIVER_OPS, > > .fops = &vc4_drm_fops, > >
On Wed, 9 Oct 2024 at 12:02, Maíra Canal <mcanal@igalia.com> wrote: > > Hi Dave, > > On 10/2/24 12:06, Dave Stevenson wrote: > > Commit 45903624e9fc ("drm/vc4: Run DRM default client setup") > > only added DRM_FBDEV_DMA_DRIVER_OPS for the vc4 (Pi0-3) driver > > definition, which caused an issue on vc5 (Pi4) as there was no > > fbdev_probe function defined. > > > > Fixes: 45903624e9fc ("drm/vc4: Run DRM default client setup") > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > Reviewed-by: Maíra Canal <mcanal@igalia.com> Applied to drm-misc-next. > Best Regards, > - Maíra > > > --- > > drivers/gpu/drm/vc4/vc4_drv.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c > > index 13a1ecddbca3..a238f76a6073 100644 > > --- a/drivers/gpu/drm/vc4/vc4_drv.c > > +++ b/drivers/gpu/drm/vc4/vc4_drv.c > > @@ -238,6 +238,7 @@ const struct drm_driver vc5_drm_driver = { > > #endif > > > > DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(vc5_dumb_create), > > + DRM_FBDEV_DMA_DRIVER_OPS, > > > > .fops = &vc4_drm_fops, > > > >
Hi Maxime & Thomas. Sorry, I'm still learning the processes. This patch and the 3 from https://patchwork.freedesktop.org/series/139716/ are in drm-misc-next, but they are fixes needed for 6.12. Am I right in thinking I need to "dim cherry-pick" them to drm-misc-fixes so they get merged there? Thanks Dave On Wed, 9 Oct 2024 at 13:15, Dave Stevenson <dave.stevenson@raspberrypi.com> wrote: > > On Wed, 9 Oct 2024 at 12:02, Maíra Canal <mcanal@igalia.com> wrote: > > > > Hi Dave, > > > > On 10/2/24 12:06, Dave Stevenson wrote: > > > Commit 45903624e9fc ("drm/vc4: Run DRM default client setup") > > > only added DRM_FBDEV_DMA_DRIVER_OPS for the vc4 (Pi0-3) driver > > > definition, which caused an issue on vc5 (Pi4) as there was no > > > fbdev_probe function defined. > > > > > > Fixes: 45903624e9fc ("drm/vc4: Run DRM default client setup") > > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > > > Reviewed-by: Maíra Canal <mcanal@igalia.com> > > Applied to drm-misc-next. > > > Best Regards, > > - Maíra > > > > > --- > > > drivers/gpu/drm/vc4/vc4_drv.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c > > > index 13a1ecddbca3..a238f76a6073 100644 > > > --- a/drivers/gpu/drm/vc4/vc4_drv.c > > > +++ b/drivers/gpu/drm/vc4/vc4_drv.c > > > @@ -238,6 +238,7 @@ const struct drm_driver vc5_drm_driver = { > > > #endif > > > > > > DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(vc5_dumb_create), > > > + DRM_FBDEV_DMA_DRIVER_OPS, > > > > > > .fops = &vc4_drm_fops, > > > > > >
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 13a1ecddbca3..a238f76a6073 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -238,6 +238,7 @@ const struct drm_driver vc5_drm_driver = { #endif DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(vc5_dumb_create), + DRM_FBDEV_DMA_DRIVER_OPS, .fops = &vc4_drm_fops,
Commit 45903624e9fc ("drm/vc4: Run DRM default client setup") only added DRM_FBDEV_DMA_DRIVER_OPS for the vc4 (Pi0-3) driver definition, which caused an issue on vc5 (Pi4) as there was no fbdev_probe function defined. Fixes: 45903624e9fc ("drm/vc4: Run DRM default client setup") Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+)