From patchwork Mon Oct 14 07:16:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13834220 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36A0ECFC501 for ; Mon, 14 Oct 2024 07:17:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ADDA710E39E; Mon, 14 Oct 2024 07:17:33 +0000 (UTC) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1237A10E39E for ; Mon, 14 Oct 2024 07:17:31 +0000 (UTC) Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XRpRz2PCZz1j9rS; Mon, 14 Oct 2024 15:16:15 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 97FD71400DA; Mon, 14 Oct 2024 15:17:26 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 14 Oct 2024 15:17:25 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , CC: Subject: [PATCH 2/3] drm/ttm/tests: Fix memory leak in ttm_tt_simple_create() Date: Mon, 14 Oct 2024 15:16:31 +0800 Message-ID: <20241014071632.989108-3-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241014071632.989108-1-ruanjinjie@huawei.com> References: <20241014071632.989108-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemh500013.china.huawei.com (7.202.181.146) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" modprobe ttm_device_test and then rmmod ttm_device_test, the fllowing memory leaks occurs: The ttm->pages allocated in ttm_tt_init() is not freed after calling ttm_tt_simple_create(), which cause the memory leak: unreferenced object 0xffffff80caf27750 (size 8): comm "kunit_try_catch", pid 2242, jiffies 4295055735 hex dump (first 8 bytes): c0 1e 3d c3 fe ff ff ff ..=..... backtrace (crc 3d11615a): [<000000007f57312a>] kmemleak_alloc+0x34/0x40 [<000000008c6c4c7e>] __kmalloc_node_noprof+0x304/0x3e4 [<00000000679c1182>] __kvmalloc_node_noprof+0x1c/0x144 [<000000006aed0a3d>] ttm_tt_init+0x138/0x28c [ttm] [<000000005c331998>] drm_gem_shmem_free+0x60/0x534 [drm_shmem_helper] [<0000000022b4f375>] kunit_try_run_case+0x13c/0x3ac [<00000000c525d725>] kunit_generic_run_threadfn_adapter+0x80/0xec [<000000002db94a1f>] kthread+0x2e8/0x374 [<000000002c457ad7>] ret_from_fork+0x10/0x20 ...... Fix it by calling ttm_tt_fini() in the exit function. Cc: stable@vger.kernel.org Fixes: e6f7c641fae3 ("drm/ttm/tests: Add tests for ttm_tt") Signed-off-by: Jinjie Ruan Reviewed-by: Nirmoy Das --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index b91c13f46225..9ff216ec58ef 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c @@ -54,6 +54,7 @@ static struct ttm_tt *ttm_tt_simple_create(struct ttm_buffer_object *bo, u32 pag static void ttm_tt_simple_destroy(struct ttm_device *bdev, struct ttm_tt *ttm) { + ttm_tt_fini(ttm); kfree(ttm); }