| Message ID | 20241020083836.175733-1-ryan@testtoast.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] drm: panel: nv3052c: correct spi_device_id for RG35XX panel | expand |
On Sun, Oct 20, 2024 at 09:37:41PM +1300, Ryan Walklin wrote: > The Anbernic RG35XX devices use an SPI LCD panel from an unknown OEM, > with an NV3052C driver chip. > > As discussed previously, the integrating vendor and device name are > preferred instead of the OEM serial. A previous patch corrected the > device tree binding and of_device_id in the NV3052C driver, however the > spi_device_id also needs correction. > > Correct the spi_device_id for the RG35XX panel. > > Signed-off-by: Ryan Walklin <ryan@testtoast.com> > Fixes: 76dce2a9 ("drm: panel: nv3052c: Correct WL-355608-A8 panel compatible") I had to fix the Fixes tag when applying the patch. It is recommended to use 12 chars of the commit id. For example in my ~/.gitconfig I have the following part, so `git log --pretty=fixes` gives me correct Fixes line: [pretty] fixes = %C(auto)commit %H%Creset%nFixes: %h (\"%s\")%nAuthor: %aN <%aE>%nDate: %aD%nComitter-Date: %cD%n%n%w(0,4,4)%b > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c > index d3baccfe6286b..06e16a7c14a75 100644 > --- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c > +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c > @@ -917,7 +917,7 @@ static const struct nv3052c_panel_info wl_355608_a8_panel_info = { > static const struct spi_device_id nv3052c_ids[] = { > { "ltk035c5444t", }, > { "fs035vg158", }, > - { "wl-355608-a8", }, > + { "rg35xx-plus-panel", }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(spi, nv3052c_ids); > -- > 2.47.0 >
On Sun, 20 Oct 2024 21:37:41 +1300, Ryan Walklin wrote: > The Anbernic RG35XX devices use an SPI LCD panel from an unknown OEM, > with an NV3052C driver chip. > > As discussed previously, the integrating vendor and device name are > preferred instead of the OEM serial. A previous patch corrected the > device tree binding and of_device_id in the NV3052C driver, however the > spi_device_id also needs correction. > > [...] Applied to drm-misc-next, thanks! [1/1] drm: panel: nv3052c: correct spi_device_id for RG35XX panel commit: 45608a3eb4902f32010a8328c0a01ccda4b38c9b Best regards,
Hello, Unfortunately, I've found that the recent Anbernic RG35XX Plus uses a new panel labeled `YLM-LBV0345001H-V2`, which is not compatible with the `WL-355608-A8` in its initialization sequence. Thus, the name `rg35xx-plus-panel` is no longer a unique identifier for the panel. I think it should be renamed to `anbernic,wl-355608-a8` to distinguish them, and `anbernic,ylm-lbv0345001h-v2` should be added for the new panel. Best regards, kikuchan. On Sun, Oct 20, 2024 at 8:34 PM Dmitry Baryshkov < dmitry.baryshkov@linaro.org> wrote: > > On Sun, 20 Oct 2024 21:37:41 +1300, Ryan Walklin wrote: > > The Anbernic RG35XX devices use an SPI LCD panel from an unknown OEM, > > with an NV3052C driver chip. > > > > As discussed previously, the integrating vendor and device name are > > preferred instead of the OEM serial. A previous patch corrected the > > device tree binding and of_device_id in the NV3052C driver, however the > > spi_device_id also needs correction. > > > > [...] > > Applied to drm-misc-next, thanks! > > [1/1] drm: panel: nv3052c: correct spi_device_id for RG35XX panel > commit: 45608a3eb4902f32010a8328c0a01ccda4b38c9b > > Best regards, > -- > With best wishes > Dmitry >
diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c index d3baccfe6286b..06e16a7c14a75 100644 --- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c @@ -917,7 +917,7 @@ static const struct nv3052c_panel_info wl_355608_a8_panel_info = { static const struct spi_device_id nv3052c_ids[] = { { "ltk035c5444t", }, { "fs035vg158", }, - { "wl-355608-a8", }, + { "rg35xx-plus-panel", }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(spi, nv3052c_ids);