diff mbox series

drm/fourcc: add AMD_FMT_MOD_TILE_GFX9_4K_D_X

Message ID 20241025060244.535406-1-Qiang.Yu@amd.com (mailing list archive)
State New, archived
Headers show
Series drm/fourcc: add AMD_FMT_MOD_TILE_GFX9_4K_D_X | expand

Commit Message

Qiang Yu Oct. 25, 2024, 6:02 a.m. UTC 
From: Qiang Yu <qiang.yu@amd.com>

This is used when radeonsi export small texture's modifier
to user with eglExportDMABUFImageQueryMESA().

mesa changes is available here:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31658

Signed-off-by: Qiang Yu <qiang.yu@amd.com>
---
 include/uapi/drm/drm_fourcc.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Marek Olšák Oct. 25, 2024, 10:22 a.m. UTC | #1 
Reviewed-by: Marek Olšák <marek.olsak@amd.com>

BTW, we don't have to define everything here. We can use most of the
32 values freely.

Marek

On Fri, Oct 25, 2024 at 2:03 AM Qiang Yu <Qiang.Yu@amd.com> wrote:
>
> From: Qiang Yu <qiang.yu@amd.com>
>
> This is used when radeonsi export small texture's modifier
> to user with eglExportDMABUFImageQueryMESA().
>
> mesa changes is available here:
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31658
>
> Signed-off-by: Qiang Yu <qiang.yu@amd.com>
> ---
>  include/uapi/drm/drm_fourcc.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 78abd819fd62..70f3b00b0681 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -1516,6 +1516,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)
>   * 64K_D_2D on GFX12 is identical to 64K_D on GFX11.
>   */
>  #define AMD_FMT_MOD_TILE_GFX9_64K_D 10
> +#define AMD_FMT_MOD_TILE_GFX9_4K_D_X 22
>  #define AMD_FMT_MOD_TILE_GFX9_64K_S_X 25
>  #define AMD_FMT_MOD_TILE_GFX9_64K_D_X 26
>  #define AMD_FMT_MOD_TILE_GFX9_64K_R_X 27
> --
> 2.43.0
>
Alex Deucher Oct. 29, 2024, 2:15 p.m. UTC | #2 
On Fri, Oct 25, 2024 at 2:03 AM Qiang Yu <Qiang.Yu@amd.com> wrote:
>
> From: Qiang Yu <qiang.yu@amd.com>
>
> This is used when radeonsi export small texture's modifier
> to user with eglExportDMABUFImageQueryMESA().
>
> mesa changes is available here:
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31658
>
> Signed-off-by: Qiang Yu <qiang.yu@amd.com>

I assume you will push this directly to amd-staging-drm-next?

Alex

> ---
>  include/uapi/drm/drm_fourcc.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 78abd819fd62..70f3b00b0681 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -1516,6 +1516,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)
>   * 64K_D_2D on GFX12 is identical to 64K_D on GFX11.
>   */
>  #define AMD_FMT_MOD_TILE_GFX9_64K_D 10
> +#define AMD_FMT_MOD_TILE_GFX9_4K_D_X 22
>  #define AMD_FMT_MOD_TILE_GFX9_64K_S_X 25
>  #define AMD_FMT_MOD_TILE_GFX9_64K_D_X 26
>  #define AMD_FMT_MOD_TILE_GFX9_64K_R_X 27
> --
> 2.43.0
>
Qiang Yu Nov. 11, 2024, 1:02 p.m. UTC | #3 
On Tue, Oct 29, 2024 at 10:15 PM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> On Fri, Oct 25, 2024 at 2:03 AM Qiang Yu <Qiang.Yu@amd.com> wrote:
> >
> > From: Qiang Yu <qiang.yu@amd.com>
> >
> > This is used when radeonsi export small texture's modifier
> > to user with eglExportDMABUFImageQueryMESA().
> >
> > mesa changes is available here:
> > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31658
> >
> > Signed-off-by: Qiang Yu <qiang.yu@amd.com>
>
> I assume you will push this directly to amd-staging-drm-next?
>
Yes, I did.

>
> > ---
> >  include/uapi/drm/drm_fourcc.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> > index 78abd819fd62..70f3b00b0681 100644
> > --- a/include/uapi/drm/drm_fourcc.h
> > +++ b/include/uapi/drm/drm_fourcc.h
> > @@ -1516,6 +1516,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)
> >   * 64K_D_2D on GFX12 is identical to 64K_D on GFX11.
> >   */
> >  #define AMD_FMT_MOD_TILE_GFX9_64K_D 10
> > +#define AMD_FMT_MOD_TILE_GFX9_4K_D_X 22
> >  #define AMD_FMT_MOD_TILE_GFX9_64K_S_X 25
> >  #define AMD_FMT_MOD_TILE_GFX9_64K_D_X 26
> >  #define AMD_FMT_MOD_TILE_GFX9_64K_R_X 27
> > --
> > 2.43.0
> >
diff mbox series

Patch

diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 78abd819fd62..70f3b00b0681 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -1516,6 +1516,7 @@  drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)
  * 64K_D_2D on GFX12 is identical to 64K_D on GFX11.
  */
 #define AMD_FMT_MOD_TILE_GFX9_64K_D 10
+#define AMD_FMT_MOD_TILE_GFX9_4K_D_X 22
 #define AMD_FMT_MOD_TILE_GFX9_64K_S_X 25
 #define AMD_FMT_MOD_TILE_GFX9_64K_D_X 26
 #define AMD_FMT_MOD_TILE_GFX9_64K_R_X 27