diff mbox series

drm/edid: add non-desktop quirk to XREAL Air/Air 2 Pro

Message ID 20241028221055.778851-1-contact@scrumplex.net (mailing list archive)
State New, archived
Headers show
Series drm/edid: add non-desktop quirk to XREAL Air/Air 2 Pro | expand

Commit Message

Sefa Eyeoglu Oct. 28, 2024, 10:10 p.m. UTC
Both devices lack a DisplayID 2.0 block and therefore do not advertise
themselves as HMDs.

See https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/53

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
---
 drivers/gpu/drm/drm_edid.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jani Nikula Oct. 29, 2024, 8:34 a.m. UTC | #1
On Mon, 28 Oct 2024, Sefa Eyeoglu <contact@scrumplex.net> wrote:
> Both devices lack a DisplayID 2.0 block and therefore do not advertise
> themselves as HMDs.
>
> See https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/53

Please attach the EDIDs to the bug.

BR,
Jani.

>
> Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
> ---
>  drivers/gpu/drm/drm_edid.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 855beafb76ff..bc13f6ef2c5d 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -219,6 +219,10 @@ static const struct edid_quirk {
>  	EDID_QUIRK('V', 'L', 'V', 0x91be, EDID_QUIRK_NON_DESKTOP),
>  	EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP),
>  
> +	/* XREAL Air series AR glasses */
> +	EDID_QUIRK('M', 'R', 'G', 0x3132, EDID_QUIRK_NON_DESKTOP),
> +	EDID_QUIRK('M', 'R', 'G', 0x3135, EDID_QUIRK_NON_DESKTOP),
> +
>  	/* HTC Vive and Vive Pro VR Headsets */
>  	EDID_QUIRK('H', 'V', 'R', 0xaa01, EDID_QUIRK_NON_DESKTOP),
>  	EDID_QUIRK('H', 'V', 'R', 0xaa02, EDID_QUIRK_NON_DESKTOP),
Sefa Eyeoglu Oct. 29, 2024, 8:48 a.m. UTC | #2
On Tue, 2024-10-29 at 10:34 +0200, Jani Nikula wrote:
> On Mon, 28 Oct 2024, Sefa Eyeoglu <contact@scrumplex.net> wrote:
> > Both devices lack a DisplayID 2.0 block and therefore do not
> > advertise
> > themselves as HMDs.
> > 
> > See https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/53
> 
> Please attach the EDIDs to the bug.
> 
> BR,
> Jani.

I had attached the outputs of edid-decode in collapsibles already. I
also attached the binary EDID files now.


KR,

Sefa

> 
> > 
> > Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
> > ---
> >  drivers/gpu/drm/drm_edid.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_edid.c
> > b/drivers/gpu/drm/drm_edid.c
> > index 855beafb76ff..bc13f6ef2c5d 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -219,6 +219,10 @@ static const struct edid_quirk {
> >  	EDID_QUIRK('V', 'L', 'V', 0x91be, EDID_QUIRK_NON_DESKTOP),
> >  	EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP),
> >  
> > +	/* XREAL Air series AR glasses */
> > +	EDID_QUIRK('M', 'R', 'G', 0x3132, EDID_QUIRK_NON_DESKTOP),
> > +	EDID_QUIRK('M', 'R', 'G', 0x3135, EDID_QUIRK_NON_DESKTOP),
> > +
> >  	/* HTC Vive and Vive Pro VR Headsets */
> >  	EDID_QUIRK('H', 'V', 'R', 0xaa01, EDID_QUIRK_NON_DESKTOP),
> >  	EDID_QUIRK('H', 'V', 'R', 0xaa02, EDID_QUIRK_NON_DESKTOP),
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 855beafb76ff..bc13f6ef2c5d 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -219,6 +219,10 @@  static const struct edid_quirk {
 	EDID_QUIRK('V', 'L', 'V', 0x91be, EDID_QUIRK_NON_DESKTOP),
 	EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP),
 
+	/* XREAL Air series AR glasses */
+	EDID_QUIRK('M', 'R', 'G', 0x3132, EDID_QUIRK_NON_DESKTOP),
+	EDID_QUIRK('M', 'R', 'G', 0x3135, EDID_QUIRK_NON_DESKTOP),
+
 	/* HTC Vive and Vive Pro VR Headsets */
 	EDID_QUIRK('H', 'V', 'R', 0xaa01, EDID_QUIRK_NON_DESKTOP),
 	EDID_QUIRK('H', 'V', 'R', 0xaa02, EDID_QUIRK_NON_DESKTOP),