diff mbox series

[1/2] drm/cirrus: Use virtual encoder and connector types

Message ID 20241029143928.208349-2-tzimmermann@suse.de (mailing list archive)
State New, archived
Headers show
Series drm/cirrus: Don't pretend to operate hardware | expand

Commit Message

Thomas Zimmermann Oct. 29, 2024, 2:34 p.m. UTC 
The cirrus driver only works on emulated Cirrus hardware. Use the
correct types for encoder and connector.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/tiny/cirrus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dmitry Baryshkov Nov. 23, 2024, 4:28 p.m. UTC | #1 
On Tue, Oct 29, 2024 at 03:34:23PM +0100, Thomas Zimmermann wrote:
> The cirrus driver only works on emulated Cirrus hardware. Use the
> correct types for encoder and connector.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>  drivers/gpu/drm/tiny/cirrus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/tiny/cirrus.c
> index f06a2be71f60..0231bdf94b8a 100644
> --- a/drivers/gpu/drm/tiny/cirrus.c
> +++ b/drivers/gpu/drm/tiny/cirrus.c
> @@ -587,14 +587,14 @@ static int cirrus_pipe_init(struct cirrus_device *cirrus)
>  
>  	encoder = &cirrus->encoder;
>  	ret = drm_encoder_init(dev, encoder, &cirrus_encoder_funcs,
> -			       DRM_MODE_ENCODER_DAC, NULL);
> +			       DRM_MODE_ENCODER_VIRTUAL, NULL);
>  	if (ret)
>  		return ret;
>  	encoder->possible_crtcs = drm_crtc_mask(crtc);
>  
>  	connector = &cirrus->connector;
>  	ret = drm_connector_init(dev, connector, &cirrus_connector_funcs,
> -				 DRM_MODE_CONNECTOR_VGA);
> +				 DRM_MODE_CONNECTOR_VIRTUAL);

This will also remove the EDID property from this connector. I'm not
sore if that is an expected behaviour or not.

>  	if (ret)
>  		return ret;
>  	drm_connector_helper_add(connector, &cirrus_connector_helper_funcs);
> -- 
> 2.46.0
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/tiny/cirrus.c
index f06a2be71f60..0231bdf94b8a 100644
--- a/drivers/gpu/drm/tiny/cirrus.c
+++ b/drivers/gpu/drm/tiny/cirrus.c
@@ -587,14 +587,14 @@  static int cirrus_pipe_init(struct cirrus_device *cirrus)
 
 	encoder = &cirrus->encoder;
 	ret = drm_encoder_init(dev, encoder, &cirrus_encoder_funcs,
-			       DRM_MODE_ENCODER_DAC, NULL);
+			       DRM_MODE_ENCODER_VIRTUAL, NULL);
 	if (ret)
 		return ret;
 	encoder->possible_crtcs = drm_crtc_mask(crtc);
 
 	connector = &cirrus->connector;
 	ret = drm_connector_init(dev, connector, &cirrus_connector_funcs,
-				 DRM_MODE_CONNECTOR_VGA);
+				 DRM_MODE_CONNECTOR_VIRTUAL);
 	if (ret)
 		return ret;
 	drm_connector_helper_add(connector, &cirrus_connector_helper_funcs);