| Message ID | 20241104190636.274926-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Use of_property_present() for non-boolean properties | expand |
On 11/4/2024 11:06 AM, Rob Herring (Arm) wrote: > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > drivers/gpu/drm/bridge/ite-it66121.c | 2 +- > drivers/gpu/drm/bridge/sii902x.c | 2 +- > drivers/gpu/drm/drm_panel.c | 2 +- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > For MSM part, Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Hi Rob, Thank you for the patch. On Mon, Nov 04, 2024 at 01:06:35PM -0600, Rob Herring (Arm) wrote: > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/bridge/ite-it66121.c | 2 +- > drivers/gpu/drm/bridge/sii902x.c | 2 +- > drivers/gpu/drm/drm_panel.c | 2 +- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c > index 925e42f46cd8..0eae7c01b975 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -1480,7 +1480,7 @@ static int it66121_audio_codec_init(struct it66121_ctx *ctx, struct device *dev) > > dev_dbg(dev, "%s\n", __func__); > > - if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { > + if (!of_property_present(dev->of_node, "#sound-dai-cells")) { > dev_info(dev, "No \"#sound-dai-cells\", no audio\n"); > return 0; > } > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c > index 7f91b0db161e..f73e1174a5ad 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -850,7 +850,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x, > u8 lanes[4]; > int num_lanes, i; > > - if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { > + if (!of_property_present(dev->of_node, "#sound-dai-cells")) { > dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n", > __func__); > return 0; > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index 19ab0a794add..46d61cc871ca 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -413,7 +413,7 @@ bool drm_is_panel_follower(struct device *dev) > * don't bother trying to parse it here. We just need to know if the > * property is there. > */ > - return of_property_read_bool(dev->of_node, "panel"); > + return of_property_present(dev->of_node, "panel"); > } > EXPORT_SYMBOL(drm_is_panel_follower); > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 185d7de0bf37..78cac4ecc58f 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -1831,7 +1831,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host *msm_host) > msm_dsi->te_source = devm_kstrdup(dev, te_source, GFP_KERNEL); > ret = 0; > > - if (of_property_read_bool(np, "syscon-sfpb")) { > + if (of_property_present(np, "syscon-sfpb")) { > msm_host->sfpb = syscon_regmap_lookup_by_phandle(np, > "syscon-sfpb"); > if (IS_ERR(msm_host->sfpb)) {
Hello Rob, On 2024-11-04 20:06, Rob Herring (Arm) wrote: > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Looking good to me, thanks for the patch! Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > drivers/gpu/drm/bridge/ite-it66121.c | 2 +- > drivers/gpu/drm/bridge/sii902x.c | 2 +- > drivers/gpu/drm/drm_panel.c | 2 +- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c > b/drivers/gpu/drm/bridge/ite-it66121.c > index 925e42f46cd8..0eae7c01b975 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -1480,7 +1480,7 @@ static int it66121_audio_codec_init(struct > it66121_ctx *ctx, struct device *dev) > > dev_dbg(dev, "%s\n", __func__); > > - if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { > + if (!of_property_present(dev->of_node, "#sound-dai-cells")) { > dev_info(dev, "No \"#sound-dai-cells\", no audio\n"); > return 0; > } > diff --git a/drivers/gpu/drm/bridge/sii902x.c > b/drivers/gpu/drm/bridge/sii902x.c > index 7f91b0db161e..f73e1174a5ad 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -850,7 +850,7 @@ static int sii902x_audio_codec_init(struct sii902x > *sii902x, > u8 lanes[4]; > int num_lanes, i; > > - if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { > + if (!of_property_present(dev->of_node, "#sound-dai-cells")) { > dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n", > __func__); > return 0; > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index 19ab0a794add..46d61cc871ca 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -413,7 +413,7 @@ bool drm_is_panel_follower(struct device *dev) > * don't bother trying to parse it here. We just need to know if the > * property is there. > */ > - return of_property_read_bool(dev->of_node, "panel"); > + return of_property_present(dev->of_node, "panel"); > } > EXPORT_SYMBOL(drm_is_panel_follower); > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c > b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 185d7de0bf37..78cac4ecc58f 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -1831,7 +1831,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host > *msm_host) > msm_dsi->te_source = devm_kstrdup(dev, te_source, GFP_KERNEL); > ret = 0; > > - if (of_property_read_bool(np, "syscon-sfpb")) { > + if (of_property_present(np, "syscon-sfpb")) { > msm_host->sfpb = syscon_regmap_lookup_by_phandle(np, > "syscon-sfpb"); > if (IS_ERR(msm_host->sfpb)) {
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index 925e42f46cd8..0eae7c01b975 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -1480,7 +1480,7 @@ static int it66121_audio_codec_init(struct it66121_ctx *ctx, struct device *dev) dev_dbg(dev, "%s\n", __func__); - if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { + if (!of_property_present(dev->of_node, "#sound-dai-cells")) { dev_info(dev, "No \"#sound-dai-cells\", no audio\n"); return 0; } diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 7f91b0db161e..f73e1174a5ad 100644 --- a/drivers/gpu/drm/bridge/sii902x.c +++ b/drivers/gpu/drm/bridge/sii902x.c @@ -850,7 +850,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x, u8 lanes[4]; int num_lanes, i; - if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { + if (!of_property_present(dev->of_node, "#sound-dai-cells")) { dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n", __func__); return 0; diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index 19ab0a794add..46d61cc871ca 100644 --- a/drivers/gpu/drm/drm_panel.c +++ b/drivers/gpu/drm/drm_panel.c @@ -413,7 +413,7 @@ bool drm_is_panel_follower(struct device *dev) * don't bother trying to parse it here. We just need to know if the * property is there. */ - return of_property_read_bool(dev->of_node, "panel"); + return of_property_present(dev->of_node, "panel"); } EXPORT_SYMBOL(drm_is_panel_follower); diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 185d7de0bf37..78cac4ecc58f 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -1831,7 +1831,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host *msm_host) msm_dsi->te_source = devm_kstrdup(dev, te_source, GFP_KERNEL); ret = 0; - if (of_property_read_bool(np, "syscon-sfpb")) { + if (of_property_present(np, "syscon-sfpb")) { msm_host->sfpb = syscon_regmap_lookup_by_phandle(np, "syscon-sfpb"); if (IS_ERR(msm_host->sfpb)) {
The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/gpu/drm/bridge/ite-it66121.c | 2 +- drivers/gpu/drm/bridge/sii902x.c | 2 +- drivers/gpu/drm/drm_panel.c | 2 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)