| Message ID | 20241105090207.3892242-1-fshao@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] dt-bindings: display: mediatek: dp: Reference common DAI properties | expand |
On Tue, 05 Nov 2024 17:00:28 +0800, Fei Shao wrote: > The MediaTek DP hardware supports audio and exposes a DAI, so the > '#sound-dai-cells' property is needed for describing the DAI links. > > Reference the dai-common.yaml schema to allow '#sound-dai-cells' to be > used, and filter out non-DP compatibles as MediaTek eDP in the same > binding doesn't support audio. > > This fixes dtbs_check error: > '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Fei Shao <fshao@chromium.org> > --- > > Changes in v2: > - reference to dai-common.yaml since the hardware exposes DAI > and update to `unevaluatedProperties: false` > - update commit message > > .../display/mediatek/mediatek,dp.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Hi, Fei: Fei Shao <fshao@chromium.org> 於 2024年11月5日 週二 下午5:02寫道： > > The MediaTek DP hardware supports audio and exposes a DAI, so the > '#sound-dai-cells' property is needed for describing the DAI links. > > Reference the dai-common.yaml schema to allow '#sound-dai-cells' to be > used, and filter out non-DP compatibles as MediaTek eDP in the same > binding doesn't support audio. > > This fixes dtbs_check error: > '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+' Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes Regards, Chun-Kuang. > > Signed-off-by: Fei Shao <fshao@chromium.org> > --- > > Changes in v2: > - reference to dai-common.yaml since the hardware exposes DAI > and update to `unevaluatedProperties: false` > - update commit message > > .../display/mediatek/mediatek,dp.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > index 2aef1eb32e11..75ce92f4a5fd 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > @@ -42,6 +42,9 @@ properties: > interrupts: > maxItems: 1 > > + '#sound-dai-cells': > + const: 0 > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > properties: > @@ -85,7 +88,21 @@ required: > - ports > - max-linkrate-mhz > > -additionalProperties: false > +allOf: > + - $ref: /schemas/sound/dai-common.yaml# > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8188-dp-tx > + - mediatek,mt8195-dp-tx > + then: > + properties: > + '#sound-dai-cells': false > + > +unevaluatedProperties: false > > examples: > - | > -- > 2.47.0.277.g8800431eea-goog >
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml index 2aef1eb32e11..75ce92f4a5fd 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml @@ -42,6 +42,9 @@ properties: interrupts: maxItems: 1 + '#sound-dai-cells': + const: 0 + ports: $ref: /schemas/graph.yaml#/properties/ports properties: @@ -85,7 +88,21 @@ required: - ports - max-linkrate-mhz -additionalProperties: false +allOf: + - $ref: /schemas/sound/dai-common.yaml# + - if: + not: + properties: + compatible: + contains: + enum: + - mediatek,mt8188-dp-tx + - mediatek,mt8195-dp-tx + then: + properties: + '#sound-dai-cells': false + +unevaluatedProperties: false examples: - |
The MediaTek DP hardware supports audio and exposes a DAI, so the '#sound-dai-cells' property is needed for describing the DAI links. Reference the dai-common.yaml schema to allow '#sound-dai-cells' to be used, and filter out non-DP compatibles as MediaTek eDP in the same binding doesn't support audio. This fixes dtbs_check error: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Fei Shao <fshao@chromium.org> --- Changes in v2: - reference to dai-common.yaml since the hardware exposes DAI and update to `unevaluatedProperties: false` - update commit message .../display/mediatek/mediatek,dp.yaml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)