diff mbox series

drm/panel-edp: Add KDB KD116N2130B12

Message ID 20241113090022.332586-1-yelangyan@huaqin.corp-partner.google.com (mailing list archive)
State New, archived
Headers show
Series drm/panel-edp: Add KDB KD116N2130B12 | expand

Commit Message

Langyan Ye Nov. 13, 2024, 9 a.m. UTC
Add support for the KDB KD116N2130B12, pleace the EDID here for
subsequent reference.
00 ff ff ff ff ff ff 00 2c 82 07 17 00 00 00 00
1c 21 01 04 95 1a 0e 78 0a 63 25 99 5b 5d 96 26
18 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 87 1b 56 88 50 00 0e 30 28 20
55 00 00 90 10 00 00 18 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fe
00 4b 44 31 31 36 4e 32 31 33 30 42 31 32 00 17

Signed-off-by: Langyan Ye <yelangyan@huaqin.corp-partner.google.com>
---
 drivers/gpu/drm/panel/panel-edp.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Doug Anderson Nov. 14, 2024, 9:01 p.m. UTC | #1
Hi,

On Wed, Nov 13, 2024 at 1:00 AM Langyan Ye
<yelangyan@huaqin.corp-partner.google.com> wrote:
>
> Add support for the KDB KD116N2130B12, pleace the EDID here for
> subsequent reference.
> 00 ff ff ff ff ff ff 00 2c 82 07 17 00 00 00 00
> 1c 21 01 04 95 1a 0e 78 0a 63 25 99 5b 5d 96 26
> 18 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 87 1b 56 88 50 00 0e 30 28 20
> 55 00 00 90 10 00 00 18 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fe
> 00 4b 44 31 31 36 4e 32 31 33 30 42 31 32 00 17
>
> Signed-off-by: Langyan Ye <yelangyan@huaqin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 012dfbcb9475..5355acd52f0b 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1978,6 +1978,12 @@ static const struct panel_delay delay_200_500_e50_po2e200 = {
>         .powered_on_to_enable = 200,
>  };
>
> +static const struct panel_delay delay_200_150_e50 = {
> +       .hpd_absent = 200,
> +       .unprepare = 150,
> +       .enable = 50,
> +};
> +
>  #define EDP_PANEL_ENTRY(vend_chr_0, vend_chr_1, vend_chr_2, product_id, _delay, _name) \
>  { \
>         .ident = { \
> @@ -2134,6 +2140,7 @@ static const struct edp_panel_entry edp_panels[] = {
>         EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
>         EDP_PANEL_ENTRY('K', 'D', 'B', 0x1118, &delay_200_500_e50, "KD116N29-30NK-A005"),
>         EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"),
> +       EDP_PANEL_ENTRY('K', 'D', 'B', 0x1707, &delay_200_150_e50, "KD116N2130B12"),

In the future, please post patches against upstream Linux. For
panel-edp.c, you'd ideally want to post against
drm-misc/drm-misc-next. Specifically, in upstream the entry right
before your new one should have been "'K', 'D', 'B', 0x1212", not
"'K', 'D', 'B', 0x1120". That's been upstream for the last 6 months...

In any case, I'll resolve the conflict this time since it's trivial.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Pushed to drm-misc-next:

[1/1] drm/panel-edp: Add KDB KD116N2130B12
      commit: ae4a812a64dad3fd4f7bbcd7af215cb68af8cf8c

-Doug
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index 012dfbcb9475..5355acd52f0b 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1978,6 +1978,12 @@  static const struct panel_delay delay_200_500_e50_po2e200 = {
 	.powered_on_to_enable = 200,
 };
 
+static const struct panel_delay delay_200_150_e50 = {
+	.hpd_absent = 200,
+	.unprepare = 150,
+	.enable = 50,
+};
+
 #define EDP_PANEL_ENTRY(vend_chr_0, vend_chr_1, vend_chr_2, product_id, _delay, _name) \
 { \
 	.ident = { \
@@ -2134,6 +2140,7 @@  static const struct edp_panel_entry edp_panels[] = {
 	EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
 	EDP_PANEL_ENTRY('K', 'D', 'B', 0x1118, &delay_200_500_e50, "KD116N29-30NK-A005"),
 	EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"),
+	EDP_PANEL_ENTRY('K', 'D', 'B', 0x1707, &delay_200_150_e50, "KD116N2130B12"),
 
 	EDP_PANEL_ENTRY('K', 'D', 'C', 0x044f, &delay_200_500_e50, "KD116N9-30NH-F3"),
 	EDP_PANEL_ENTRY('K', 'D', 'C', 0x05f1, &delay_200_500_e80_d50, "KD116N5-30NV-G7"),