| Message ID | 20241117202629.1681358-1-quic_jhugo@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | accel/qaic: Drop redundant vfree() null check in sahara | expand |
On Sun, Nov 17, 2024 at 01:26:29PM -0700, Jeffrey Hugo wrote: > The documentation for vfree() says that passing in NULL is ok. Therefore > we can drop the null check as redundant. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202410301732.abF5Md4e-lkp@intel.com/ > Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com> > --- > drivers/accel/qaic/sahara.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 11/17/2024 8:26 PM, Jeffrey Hugo wrote: > The documentation for vfree() says that passing in NULL is ok. Therefore > we can drop the null check as redundant. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202410301732.abF5Md4e-lkp@intel.com/ > Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com> Reviewed-by: Youssef Samir <quic_yabdulra@quicinc.com>
On 11/17/2024 12:26 PM, Jeffrey Hugo wrote: > The documentation for vfree() says that passing in NULL is ok. Therefore > we can drop the null check as redundant. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202410301732.abF5Md4e-lkp@intel.com/ > Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com> Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
diff --git a/drivers/accel/qaic/sahara.c b/drivers/accel/qaic/sahara.c index 6d772143d612..21d58aed0deb 100644 --- a/drivers/accel/qaic/sahara.c +++ b/drivers/accel/qaic/sahara.c @@ -772,8 +772,7 @@ static void sahara_mhi_remove(struct mhi_device *mhi_dev) cancel_work_sync(&context->fw_work); cancel_work_sync(&context->dump_work); - if (context->mem_dump) - vfree(context->mem_dump); + vfree(context->mem_dump); sahara_release_image(context); mhi_unprepare_from_transfer(mhi_dev); }
The documentation for vfree() says that passing in NULL is ok. Therefore we can drop the null check as redundant. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202410301732.abF5Md4e-lkp@intel.com/ Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com> --- drivers/accel/qaic/sahara.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)